Re-introduce ajax player search - #194
Merged
Merged
Conversation
Collaborator
|
I'll merge this, but we might have to roll it back until we add optimizations if there are performance issues. |
Collaborator
Author
|
@jschnei don't worry, we debounce the typeahead now so it won't bombard the server with requests! (Try it out on staging) |
BrandonCookeDev
pushed a commit
to BrandonCookeDev/garpr
that referenced
this pull request
Jan 20, 2018
* return most relevant player matches from server if querying by string * fixes * frontend for ajax player search (rm logic, debounce) * reformat app module deps * fix filtering on promises * loading spinner for ajax call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opening #193 with the right remote repo.
Implement part 1 from this issue: #187
Instead of loading the (now very large) list of all players, make ajax requests when the user does player search.
@jschnei @garsh0p