Upgrade packager Go version to 1.26 + regression test - #667
Merged
Conversation
While trying to do a release yesterday, the final release build failed unfortunately because `packager/go.mod` specified Go 1.25, and that was too old to run the Go 1.26 found in `./go.mod`. Here, upgrade the packager to Go 1.26, and also put in a test that'll detect such a discrepancy in CI and fail on the branch rather than failing only come release time, letting us catch the problem earlier and avoid having to go back and fix up a release.
brandur
force-pushed
the
brandur-upgrade-packager
branch
from
August 26, 2026 02:32
805eb1f to
da65fff
Compare
Collaborator
Author
|
ty man. Let me try to get this thing going again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to do a release yesterday, the final release build failed
unfortunately because
packager/go.modspecified Go 1.25, and that wastoo old to run the Go 1.26 found in
./go.mod.Here, upgrade the packager to Go 1.26, and also put in a test that'll
detect such a discrepancy in CI and fail on the branch rather than
failing only come release time, letting us catch the problem earlier and
avoid having to go back and fix up a release.