Harden local services and make setup portable - #2
Open
btjones-me wants to merge 1 commit into
Open
btjones-me wants to merge 1 commit into
btjones-me wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fresh checkout currently depends on personal Java paths and a deployment-specific Google project, and its local relay/legacy recorder trust every loopback caller. This makes onboarding fragile and lets unrelated local callers consume model credit or interfere with recordings.
This change provides a documented local setup and shared security boundaries while retaining the existing 1.16.5 gameplay routes.
Changes
MC_JAVA_HOME/JAVA_HOME/PATHand ffmpeg through configuration; add verified server setup, shared Java builds, a doctor command, andSETUP.md. Preserve existing server configuration/worlds and leave EULA acceptance explicit.Validation
npm ci --ignore-scriptsfollowed bynpm run prepare:local.npm test: 115 passed.npm run test:setup: 12 Node security/lifecycle tests + 4 Python setup tests passed. Includes unauthorized/cross-origin/rebound-Host requests with zero upstream calls, oversized chunked bodies, concurrency/call limits, legitimate authenticated relay behavior, upload quotas/replay rejection, and recorder failure cleanup.npm audit --omit=dev: 0 reported vulnerabilities at validation time.--libraries-only), downloaded/verified server, and launched the server with updated Log4j and observer. It reached the expected unaccepted-EULA exit without creating a world.git diff --checkpassed.Compatibility and limits
Existing users must explicitly configure credentials and run the new setup steps. Native rendering remains macOS-only; Intel library selection is implemented but has not been live-tested. The pre-EULA server bootstrap emits legacy Mojang Log4j plugin-registration warnings. No paid model requests, EULA acceptance, complete gameplay run, or native video-rendering run was performed. A live isolated gameplay/recording check remains necessary before treating the setup as fully validated. This is hardening, not an OS sandbox or a general-purpose arbitrary-world agent.