Skip to content

feat(migrate): add monorepo support for tsup migration script - #659

Merged
sxzz merged 4 commits into
rolldown:mainfrom
lauigi:feat/monorepo-migration
Jan 5, 2026
Merged

feat(migrate): add monorepo support for tsup migration script#659
sxzz merged 4 commits into
rolldown:mainfrom
lauigi:feat/monorepo-migration

Conversation

@lauigi

@lauigi lauigi commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

Description

Add monorepo support for the tsup migration script. If executed in the monorepo root, the script will run sequentially in the current directory and in each package directory. In all other cases, it will still run only in the specified directory.

Linked Issues

Resolves #452

Additional context

The testing fixtures of this PR might not be in the best shape. Need comment.

@netlify

netlify Bot commented Dec 19, 2025

Copy link
Copy Markdown

Deploy Preview for tsdown ready!

Name Link
🔨 Latest commit 14dae41
🔍 Latest deploy log https://app.netlify.com/projects/tsdown/deploys/695c1f01954fbc0008a6daff
😎 Deploy Preview https://deploy-preview-659--tsdown.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Dec 19, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/tsdown@659
npm i https://pkg.pr.new/create-tsdown@659
npm i https://pkg.pr.new/tsdown-migrate@659

commit: 14dae41

@lauigi
lauigi force-pushed the feat/monorepo-migration branch 4 times, most recently from 8dea631 to 885cf20 Compare December 19, 2025 04:04
@lauigi lauigi changed the title feat(migrate): add monorepo support for tsup migration script (#452) feat(migrate): add monorepo support for tsup migration script Dec 19, 2025
@lauigi
lauigi force-pushed the feat/monorepo-migration branch from 885cf20 to ebaf82c Compare December 21, 2025 05:27
@sxzz
sxzz force-pushed the main branch 2 times, most recently from 710ba4e to ccd17b1 Compare December 30, 2025 04:14
@lauigi
lauigi force-pushed the feat/monorepo-migration branch from ebaf82c to 885cf20 Compare January 5, 2026 05:54

@sxzz sxzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to introduce a new dependency, so we can use tsdown-migrate [...dirs], e.g., tsdown-migrate packages/*.

Comment thread packages/migrate/src/index.ts Outdated
@lauigi
lauigi force-pushed the feat/monorepo-migration branch from 885cf20 to 159ed8c Compare January 5, 2026 18:46
@lauigi
lauigi force-pushed the feat/monorepo-migration branch from 159ed8c to 3ade8f4 Compare January 5, 2026 18:49

@sxzz sxzz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is tinyglobby really necessary? I think shells like bash will also resolve glob patterns.

@lauigi

lauigi commented Jan 5, 2026

Copy link
Copy Markdown
Contributor Author

Is tinyglobby really necessary? I think shells like bash will also resolve glob patterns.

In my local, if I remove tinyglobby and rely directly on shell expansion like this, it would break support for PowerShell on Windows.

const baseCwd = process.cwd()
  const cwds =
    dirs && dirs.length > 0
      ? dirs.map((d) => path.resolve(baseCwd, d))
      : [baseCwd]

@sxzz

sxzz commented Jan 5, 2026

Copy link
Copy Markdown
Member

Ah... PowerShell...

@sxzz
sxzz enabled auto-merge (squash) January 5, 2026 20:29
@sxzz
sxzz merged commit efba2cc into rolldown:main Jan 5, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Monorepo support for tsup migration script

2 participants