Use chef configuration in windows dockerfile setup - #425
Conversation
4a85d8c to
ca34ec3
Compare
|
This is now building and testing up to rclcpp |
|
Full builds and tests:
|
ca34ec3 to
a6649e9
Compare
|
Updated tests:
|
|
Now external dependencies are installed through berks.
|
|
If this change is only touching Windows related files why does it need to run builds on the other platforms? |
eb6fce2 to
9be96be
Compare
|
Updated cookbook, testing again (but only windows for Dirk's sake :P) |
9be96be to
637d52d
Compare
|
Cookbook should now be good to build with connext. |
|
Building again |
41d4f69 to
62b070b
Compare
45ff687 to
2779c69
Compare
* Switching dockerfile to install from chef config. * Updating cookbooks. * Add environment json file for setting chef attributes. * Add docker build argument for ROS_DISTRO. Instead of using separate dockerfiles for different ROS distros this uses separate chef environment files to set a ros_distro attribute which can be used inside the chef cookbook. If this is successful we can unify the separate Dockerfiles and modify software in the chef cookbook. * Use Docker variable syntax for build argument in COPY. * Update chef environment usage. I forgot that environment paths must be configured instead of specifying an absolute path to an environment file. * Expand environment file and add README describing directory. * Use a single string for environment_path. Unlike cookbook_path, environment_path must be a single string. * Remove environment files. We're going to instead add the attribute directly to the install_ros2.json files. * Copy install_ros.json to Dashing specific file. * Add ros_distro attribute. * Don't specify environment. * Use ros_distro-specific node file. * Re-organize dockerfiles and chef json files. * Use ROS_DISTRO build arg instead of separate Dockerfiles. With the setup being performed by chef the Dockerfiles aren't distinct enough to warrant separate files and we can instead use a single dockerfile with different chef attributes. This also means we can stop fudging the ros_distro parameter since the common behavior is also implemented in Chef. Co-authored-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
left a comment
There was a problem hiding this comment.
Merged in @nuclearsandwich's changes and addressed @j-rivero suggestions I believe.
|
Building rolling: |
|
Err, this looks like it needs the ci_job.xml.em updates to be applied. |
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Yeah this PR makes changes to the job configuration as well as the scripts and dockerfiles. I've deployed this PR to the test_ci_windows job and launched the same job there Rolling If CI calms down doing the full gamut and also testing Focal and Eloquent, which are currently identical to Rolling and Dashing respectively would be pleasantly paranoid. |
nuclearsandwich
left a comment
There was a problem hiding this comment.
A couple of small questions but as long as the final round of testing is good I think this is ready to go.
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
|
Rebuilding/testing Rolling |
Signed-off-by: Stephen Brawner <brawner@gmail.com>
|
The latest builds have a plethora of errors due to the installation of cppcheck 2.x which we don't yet support. |
|
I think this is ready. Running full builds of Rolling and Rolling Debug to compare with nightlies Rolling |
Signed-off-by: Stephen Brawner <brawner@gmail.com>
|
Updated branch to target ros-infrastructure/ros2-cookbooks#9 Rolling |
|
Updated branch of cookbooks back to latest. Building up to and testing only image_tools to confirm update. Rolling: |
|
Planning to merge and deploy before the next round of nightlies. |
Signed-off-by: Stephen Brawner <brawner@gmail.com>
This PR enables the windows dockerfile to install the ROS 2 dependencies from a chef cookbook. This will allow regular testing of the cookbook so that everyone can make use of it.
Currently this targets my personal repo, but I'll switch it over once the ros2 cookbook has a permanent home.
Depends on #424
New commit: ca34ec3