Change errorlevel to delayed expansion variable - #438
Merged
Merged
Conversation
Member
|
Why are the quotes necessary? |
Contributor
Author
|
They aren't. Removed |
cottsay
approved these changes
Apr 21, 2020
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Member
|
I can't find anything which suggests that delayed expansion will help us in this pipeline but I'm willing to try it and I've got to debug https://ci.ros2.org/job/ci_windows/10306/console so I've got failures to test it with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the batch script in ci_job.xml.em is read all environment variables that already exist are currently expanded. This had led the ERRORLEVEL variable to be set to 0 and the
exit /bcommands introduced in #428 to output success instead of failure.Signed-off-by: Stephen Brawner brawner@gmail.com