Skip to content

Don't ignore rmw_connextdds by default in linux-aarch64 - #882

Merged
knmcguire merged 6 commits into
ros2:masterfrom
fgallegosalido:feature/use-rmw-connextdds-default-arm
Sep 30, 2026
Merged

knmcguire merged 6 commits into
ros2:masterfrom
fgallegosalido:feature/use-rmw-connextdds-default-arm

Conversation

@fgallegosalido

Copy link
Copy Markdown
Contributor

Description

Currently, the Connext RMW is ignored by default in linux-aarch64. This pull request changes that so it is now used by default in the CI.

Is this user-facing behavior change?

Now the CI doesn't need to explicitly enable the Connext RMW.

Did you use Generative AI?

No

Additional Information

@mergify

mergify Bot commented Jun 26, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@fgallegosalido

Copy link
Copy Markdown
Contributor Author

@cottsay can you launch a build with the default CI parameters, to be sure the Connext RMW is not ignored?

@cottsay

cottsay commented Jun 26, 2026

Copy link
Copy Markdown
Member

This sort of change has to be deployed to be tested, so I deployed it to the "test" launcher job and triggered it: Build Status

@fgallegosalido

Copy link
Copy Markdown
Contributor Author

Thank you @cottsay! It seems the Connext RMW is no longer ignored in linux-aarch64. However, we are not using the Connext Debian packages (which are required for linux-aarch64). I can't seem to figure out how to always enable them in linux-aarch64, as I thought the change on https://github.com/ros2/ci/blob/master/create_jenkins_job.py#L144 would suffice. Do you have any idea what I am missing?

@fgallegosalido

Copy link
Copy Markdown
Contributor Author

@cottsay another question I wanted to ask is what else do we need to do to have ARM as an officially supported architecture in the REP 2000? I'm not sure if that is still getting updated or if there is any other place where the Connext RMW could be considered to support ARM moving forward.

@fgallegosalido

Copy link
Copy Markdown
Contributor Author

@cottsay any updates on this? This was still missing that the Debian packages are used by default in linux-aarch64, but I can't figure out what I'm missing for that to happen.

@fgallegosalido

Copy link
Copy Markdown
Contributor Author

@cottsay I think the trick is to force linux-aarch4 builds to use the Connext Debians by default. Let me know if this change is correct and launch a new CI please.

@knmcguire

Copy link
Copy Markdown
Collaborator

I feel a little less comfortable giving judgement to the other PR that got merged. It seems alright? What I can do is run CI for you

Build Status

@knmcguire

Copy link
Copy Markdown
Collaborator

oh wait... this requires a deployment as this is a job description change. Please disregard the above CI

Let me try that on the test server, one moment.

@knmcguire

Copy link
Copy Markdown
Collaborator

Hi!

Sorry we were hitting an regression that has now been fixed with this PR: #902

@fgallegosalido Would you mind giving this branch yet another update from the master branch? I've tested the currents state with a master merge and that seem to work but just want to make sure that we don't have any hidden changes before I squash merge. That is probably what caused the previous regression in the first place.

Thanks for your patience!

@fgallegosalido

Copy link
Copy Markdown
Contributor Author

@knmcguire done

@knmcguire knmcguire left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more changes were merged into master so I have merged the latest and did a test of that as well!

Build Status

All good. I can merge this and deploy it

@knmcguire
knmcguire merged commit 42664c2 into ros2:master Sep 30, 2026
1 check passed
@fgallegosalido

Copy link
Copy Markdown
Contributor Author

Thank you for merging this @knmcguire!

@knmcguire

Copy link
Copy Markdown
Collaborator

It has also now been deployed on https://ci.ros2.org/job/ci_linux-aarch64/ so any jobs failed on it can be run again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants