What is "oh yeah destructuro"

[BriceRenaudeau]

Bug report

Useless messages appear when killing a lifecycle node.

Required Info:

• Operating System:
  Ubuntu
• Installation type:
  Binary
• Version or commit hash:
  master
• DDS implementation:
  Cyclone
• Client library (if applicable):
  lifecycle_node_interface

Steps to reproduce the issue

When killing my lifecycle node "assisted_teleop" this message appears:

[assisted_teleop-28] [INFO] [1617022166.929935526] [assisted_teleop.local_costmap]: Destroying
[assisted_teleop-28] oh yeah destructuro
[assisted_teleop-28] oh yeah end destructuro
[assisted_teleop-28] oh yeah end destructuro222
[assisted_teleop-28] oh yeah destructuro
[assisted_teleop-28] oh yeah end destructuro
[assisted_teleop-28] oh yeah end destructuro222

Expected behavior

Only the message "Destroying" should appear

Actual behavior

Additional information

Error comes from here:

rclcpp/rclcpp_lifecycle/src/lifecycle_node_interface_impl.hpp

Lines 64 to 76 in 052596c

	~LifecycleNodeInterfaceImpl()
	{
	fprintf(stderr, "oh yeah destructuro\n");
	rcl_node_t * node_handle = node_base_interface_->get_rcl_node_handle();
	fprintf(stderr, "oh yeah end destructuro\n");
	auto ret = rcl_lifecycle_state_machine_fini(&state_machine_, node_handle);
	fprintf(stderr, "oh yeah end destructuro222\n");
	if (ret != RCL_RET_OK) {
	RCUTILS_LOG_FATAL_NAMED(
	"rclcpp_lifecycle",
	"failed to destroy rcl_state_machine");
	}
	}

[christophebedard]

It was introduced by #1507. Seems like it was just left behind and no one caught it.

[Karsten1987]

lol. Now y'all know my advanced debugging techniques ;-)

Thanks @ivanpauno for taking care of it!

[fujitatomoya]

lol 😆