Fix destruction order in lifecycle benchmark - #1675
Merged
Merged
Conversation
Signed-off-by: Scott K Logan <logans@cottsay.net>
wjwwood
approved these changes
May 14, 2021
fujitatomoya
approved these changes
May 15, 2021
Member
Author
|
@Mergifyio backport galactic |
mergify Bot
pushed a commit
that referenced
this pull request
May 15, 2021
Signed-off-by: Scott K Logan <logans@cottsay.net> (cherry picked from commit 56f68f9)
Contributor
|
Command
|
bartalor
pushed a commit
to bartalor/rclcpp
that referenced
this pull request
Jul 15, 2026
Signed-off-by: Scott K Logan <logans@cottsay.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be the last issue to get the benchmark jobs green, and I intend to backport it to Galactic as well.
Before:
After: