Skip to content

fix bugprone-exception-escape in node_main.cpp.in #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alsora merged 1 commit into from
Mar 8, 2022
Merged

fix bugprone-exception-escape in node_main.cpp.in #1895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion rclcpp_components/src/node_main.cpp.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,16 @@ int main(int argc, char * argv[])
std::string name = clazz.c_str();
if (name.compare(class_name) == 0) {
RCLCPP_DEBUG(logger, "Instantiate class %s", clazz.c_str());
auto node_factory = loader->createInstance<rclcpp_components::NodeFactory>(clazz);
std::shared_ptr<rclcpp_components::NodeFactory> node_factory = nullptr;
try {
node_factory = loader->createInstance<rclcpp_components::NodeFactory>(clazz);
} catch (const std::exception & ex) {
RCLCPP_ERROR(logger, "Failed to load library %s", ex.what());
return 1;
} catch (...) {
RCLCPP_ERROR(logger, "Failed to load library");
return 1;
}
auto wrapper = node_factory->create_node_instance(options);
auto node = wrapper.get_node_base_interface();
node_wrappers.push_back(wrapper);
Expand Down