Skip to content

Enable Monitoring Library by default - #243

Merged
ahcorde merged 1 commit into
rollingfrom
feature/enable-monitoring-library
Jun 29, 2026
Merged

ahcorde merged 1 commit into
rollingfrom
feature/enable-monitoring-library

Conversation

@fgallegosalido

Copy link
Copy Markdown
Collaborator

Description

This pull request enables the Monitoring Library in the Connext RMW by default.

Is this user-facing behavior change?

The Connext RMW will now send monitoring data by default.

Did you use Generative AI?

No

Additional Information

We had to disable the monitoring library as we were very close to the Lyrical code freeze.

@fgallegosalido

Copy link
Copy Markdown
Collaborator Author

@fujitatomoya could you backport this to Lyrical?

@mergify

mergify Bot commented Jun 25, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@ahcorde

ahcorde commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Pulls: #243
Gist: https://gist.githubusercontent.com/ahcorde/c083358f7409bd9e931b2e1c897939c1/raw/9b2d7cdd75cbb7c230c1a031306b0050b7290b55/ros2.repos
BUILD args: --packages-above-and-dependencies rmw_connextdds_common
TEST args: --packages-above rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19681

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@fujitatomoya

Copy link
Copy Markdown
Collaborator

@fgallegosalido since this changes the default behavior, probably we do not backport this lyrical?

@ahcorde
ahcorde merged commit 29da158 into rolling Jun 29, 2026
2 checks passed
@ahcorde
ahcorde deleted the feature/enable-monitoring-library branch June 29, 2026 10:37
@fgallegosalido

Copy link
Copy Markdown
Collaborator Author

@fujitatomoya we would really like to get this backported to Lyrical. A couple of reasons to do so:

  • This feature provides a way for ROS 2 users to monitor their applications through our Observability framework.
  • Right now it is explicitly disabled, and it can not be enabled by any other means.
  • This feature is transparent to users, and can easily be disabled through an environment variable if needed.
  • The next ROS 2 LTS is in 2 years, which is a long wait for getting this feature in the RMW.

@fgallegosalido

Copy link
Copy Markdown
Collaborator Author

@fujitatomoya can you check my previous bullet points? We would like to backport this pull request to Lyrical. Let me know what you think.

@oliviadorenczrti

Copy link
Copy Markdown
Collaborator

New windows failures that seem related: #248

@fgallegosalido we should wait to backport until this is resolved

@fgallegosalido

Copy link
Copy Markdown
Collaborator Author

@fujitatomoya the Windows issues have now been fixed by #250. Let me know if you have any doubts about backporting this to Lyrical.

@fujitatomoya

Copy link
Copy Markdown
Collaborator

@fgallegosalido you mean backporting #243 and #250 to lyrical, right?

@fgallegosalido

Copy link
Copy Markdown
Collaborator Author

Indeed. #250 will be necessary too.

@fujitatomoya

Copy link
Copy Markdown
Collaborator

@Mergifyio backport lyrical

@mergify

mergify Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

backport lyrical

✅ Backports have been created

Details

fujitatomoya pushed a commit that referenced this pull request Aug 20, 2026
(cherry picked from commit 29da158)

Co-authored-by: Francisco Gallego Salido <fgallego@rti.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants