Enable Monitoring Library by default - #243
Conversation
|
@fujitatomoya could you backport this to Lyrical? |
|
Tick the box to add this pull request to the merge queue (same as
|
|
Pulls: #243 |
|
@fgallegosalido since this changes the default behavior, probably we do not backport this lyrical? |
|
@fujitatomoya we would really like to get this backported to Lyrical. A couple of reasons to do so:
|
|
@fujitatomoya can you check my previous bullet points? We would like to backport this pull request to Lyrical. Let me know what you think. |
|
New windows failures that seem related: #248 @fgallegosalido we should wait to backport until this is resolved |
|
@fujitatomoya the Windows issues have now been fixed by #250. Let me know if you have any doubts about backporting this to Lyrical. |
|
@fgallegosalido you mean backporting #243 and #250 to lyrical, right? |
|
Indeed. #250 will be necessary too. |
|
@Mergifyio backport lyrical |
✅ Backports have been createdDetails
|
Description
This pull request enables the Monitoring Library in the Connext RMW by default.
Is this user-facing behavior change?
The Connext RMW will now send monitoring data by default.
Did you use Generative AI?
No
Additional Information
We had to disable the monitoring library as we were very close to the Lyrical code freeze.