change generators to IDL-based pipeline#24
Merged
Merged
Conversation
762ea8b to
b0623a2
Compare
hidmic
reviewed
Nov 27, 2018
88b69bb to
4fd9b26
Compare
jacobperron
reviewed
Feb 22, 2019
jacobperron
left a comment
Member
There was a problem hiding this comment.
Looks good.
FYI, as part of the review I've updated rclpy's ActionServer, which we can add to the idl-stage-7 branch once ros2/rclpy#270 is merged.
jacobperron
approved these changes
Feb 22, 2019
ed35aab to
2b38b79
Compare
This was referenced Mar 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connected to ros2/rosidl#334.