Fix osx build - #65
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
Why reinterpret instead of static here?
Contributor
Author
There was a problem hiding this comment.
That was leftover from experimenting with what would make it compile. Actually, no cast is needed because it will implicitly cast from the U pointer type to void*.
Member
|
if So many advanced features nowadays. What happened to C with Classes and printf ? 🐔 |
Member
|
+1 |
Contributor
Author
|
the first run built on OSX and Windows, I'm rerunning Jenkins again after making a few tweaks based on comments http://ci.ros2.org/job/ros2_batch_ci_linux/553/ |
jackieokay
force-pushed
the
fix_osx_build
branch
from
November 5, 2015 19:01
2c960d7 to
8279e72
Compare
jackieokay
force-pushed
the
fix_osx_build
branch
from
November 5, 2015 19:01
8279e72 to
2781063
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use enable_if to disable the
constructmethod if the pointer type is const in the custom allocator.