⚠️ Rename Kagenti → Rossoctl across kagenti-extensions (→ rossocortex)#678
Merged
Merged
Conversation
Full content rename Kagenti → Rossoctl. Repo renamed kagenti-extensions → rossocortex; all 1582 case-insensitive `kagenti` references updated; grep is clean. Changes: - Brand / prose / comments: Kagenti → Rossoctl - Go modules (8): github.com/kagenti/kagenti-extensions/... → github.com/rossoctl/rossocortex/... (module dirs + internal replace directives) - External dep: github.com/kagenti/context-guru → github.com/rossoctl/context-guru (renamed in lockstep per playbook §3; see caveat below) - Cross-repo refs: kagenti-operator → operator, agent-examples → examples, kagenti/kagenti → rossoctl/rossoctl - CODEOWNERS @kagenti/* → @rossoctl/*; CI reusable-workflow refs kagenti/.github → rossoctl/.github - Python dist/console-script kagenti-sparc-service → rossoctl-sparc-service - Env vars KAGENTI_* → ROSSOCTL_* - Runtime contracts (this repo's manifests/samples): CRD group agent.kagenti.dev → agent.rossoctl.dev, labels kagenti.io/* → rossoctl.io/*, namespace kagenti-system → rossoctl-system, SPIFFE kagenti.local → rossoctl.local, Keycloak realm kagenti → rossoctl, kagenti-controller-manager → rossoctl-controller-manager Verification: - pytest tests/ (excl e2e): 12 passed (unchanged from baseline) - ruff v0.9.10: 4 pre-existing errors, unchanged (none introduced) - go build: authbridge-cpex + echo/finance-sparc/ibac demos build clean - authlib/abctl/authbridge-envoy/authbridge-proxy fail to build ONLY on github.com/rossoctl/context-guru (repo not yet published) — the expected cross-repo module-path break (playbook §4). Verified via a temporary `replace` that authlib's own code compiles; resolves once context-guru is renamed + republished and `go mod tidy` is re-run. Related to #1972 Assisted-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: IBRAHIM IBRAHIM <66755652+Ibrahim2595@users.noreply.github.com>
|
Important Review skippedToo many files! This PR contains 323 files, which is 223 over the limit of 100. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (323)
You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mrsabath
requested changes
Jul 20, 2026
mrsabath
left a comment
Contributor
There was a problem hiding this comment.
Summary
The rename itself is faithful and consistent — the 8 Go modules move to github.com/rossoctl/rossocortex/... with replace directives updated in lockstep, and the manifest/CRD-group (agent.rossoctl.dev)/label (rossoctl.io/*)/namespace substitutions I spot-checked are clean. Sign-off/DCO ✅.
Requesting changes on one supply-chain correctness issue (go.sum). The single failing CI check is the expected cross-repo sequencing break, explained below.
Blocking
go.sumchecksums forcontext-guruare non-validating placeholders (inline). The dep was rewrittengithub.laiyagushi.com/kagenti/context-guru→github.com/rossoctl/context-guru, but theh1:and/go.mod h1:hashes were kept byte-identical (same in authlib, authbridge-envoy, authbridge-proxy go.sum). Go's/go.modhash is computed over the go.mod contents, whosemoduleline must becomegithub.laiyagushi.com/rossoctl/context-guruon republish — so the recorded hash cannot match. Oncerossoctl/context-guruis published,go mod verify/ build fails with a checksum mismatch for every consumer. Regenerate viago mod tidyafter the dep is republished; don't hand-edit the hashes.
Non-blocking (transition sequencing)
Go CI (authlib)fails:github.com/rossoctl/context-guruis unresolvable — the repo doesn't exist yet (404; therossoctlorg exists, the repo doesn't), sogit ls-remoteprompts for auth and the build aborts. The rewrite is correct; this is the documented cross-repo break and resolves once context-guru moves under therossoctlorg. One thing to confirm: the pseudo-versionv0.0.0-20260713113308-b624f2c3d8c2pins commitb624f2c3d8c2— verify that commit still exists (and resolves to the same tree) in the renamed repo after the org move, otherwise the pseudo-version itself will need regenerating too.
Nit
- Title is 79 chars (guideline <72) with a bare
⚠️prefix; the org title Ruleset expects an allowed word prefix (e.g.Refactor:). Currently green but may trip on a future re-run. ConsiderRefactor: Rename Kagenti → Rossoctl across kagenti-extensions (→ rossocortex).
Areas reviewed: Go modules (go.mod/go.sum ×11), CI (failure traced end-to-end), K8s manifests/samples, Python packaging, supply-chain (external dep rename), commit conventions.
CI status: 1 failing (transition sequencing), rest passing; CodeRabbit skipped (323 files > 100-file limit).
| github.com/kagenti/context-guru v0.0.0-20260713113308-b624f2c3d8c2 h1:nyu0kAd/+NlRM95IxEiRws2QyRtyyYRy8u8wjnwxn4o= | ||
| github.com/kagenti/context-guru v0.0.0-20260713113308-b624f2c3d8c2/go.mod h1:arqPc8H+3s+XjplrD0ytgv1Zum241jvuGu3139DX6p8= | ||
| github.com/rossoctl/context-guru v0.0.0-20260713113308-b624f2c3d8c2 h1:nyu0kAd/+NlRM95IxEiRws2QyRtyyYRy8u8wjnwxn4o= | ||
| github.com/rossoctl/context-guru v0.0.0-20260713113308-b624f2c3d8c2/go.mod h1:arqPc8H+3s+XjplrD0ytgv1Zum241jvuGu3139DX6p8= |
Contributor
There was a problem hiding this comment.
must-fix — these checksums won't validate.
The module path was rewritten kagenti/context-guru → rossoctl/context-guru, but both hashes were kept byte-identical:
github.com/rossoctl/context-guru v0.0.0-20260713113308-b624f2c3d8c2 h1:nyu0kAd/+NlRM95IxEiRws2QyRtyyYRy8u8wjnwxn4o=
github.com/rossoctl/context-guru v0.0.0-20260713113308-b624f2c3d8c2/go.mod h1:arqPc8H+3s+XjplrD0ytgv1Zum241jvuGu3139DX6p8=
The /go.mod h1: line hashes the go.mod file contents. When context-guru is republished under the rossoctl org, its go.mod module directive must become module github.com/rossoctl/context-guru (Go requires the module path to match the import path) — different bytes, so the /go.mod hash necessarily changes. The recorded value here is the hash of the old kagenti/context-guru go.mod, so once the renamed dep exists, go mod verify / any build fails with:
verifying github.com/rossoctl/context-guru@...: checksum mismatch
SECURITY ERROR
These are placeholder lines from the string-replace, not a correct final state. Fix: after rossoctl/context-guru is published, run go mod tidy in each affected module (authlib, authbridge-envoy, authbridge-proxy) to regenerate real checksums — don't hand-edit the h1: values. Same applies to the sibling go.sum files with the identical two-line block.
Contributor
Author
There was a problem hiding this comment.
Fixed in 2871873. You're right — these were non-validating placeholders: the string-replace kept the old kagenti/context-guru hashes, and the /go.mod hash necessarily changes once the module line becomes module github.com/rossoctl/context-guru on republish.
Since a valid checksum for a not-yet-published module can't exist, I removed the placeholder lines from all three go.sum (authlib, authbridge-envoy, authbridge-proxy) rather than record known-wrong hashes — so there's no false checksum left to trip a SECURITY ERROR later. go mod tidy regenerates real ones once rossoctl/context-guru is published. Confirmed the removal doesn't regress the currently-green modules (cpex + demos still build); authlib/envoy/proxy stay red only on the unpublished dep.
On your pseudo-version question: commit b624f2c3d8c2 exists in context-guru (dated 2026-07-13T11:33:08Z, matching v0.0.0-20260713113308-…), so it survives the org move and the version string stays resolvable — only the /go.mod hash changes, which go mod tidy handles.
The context-guru dependency was renamed github.com/kagenti/context-guru → github.com/rossoctl/context-guru, but the go.sum `h1:` and `/go.mod h1:` hashes were carried over byte-identical by the string replace. Go's `/go.mod` hash is computed over the go.mod contents, whose `module` line must become github.com/rossoctl/context-guru on republish — so the recorded hashes can never match and would trigger a `go mod verify` checksum-mismatch SECURITY ERROR for every consumer once the renamed dep is published. You can't produce a valid checksum for a module that doesn't exist yet, so rather than record known-wrong hashes, remove the placeholder lines from authlib, authbridge-envoy, and authbridge-proxy go.sum. `go mod tidy` regenerates real checksums once rossoctl/context-guru is published. The go.mod `require` (pseudo-version v0.0.0-20260713113308-b624f2c3d8c2, commit b624f2c3d8c2 — confirmed present in the repo) is unchanged; the build stays red on the unpublished dep (documented cross-repo sequencing) until the org move. Addresses review feedback on rossoctl#678. Related to #1972 Assisted-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: IBRAHIM IBRAHIM <66755652+Ibrahim2595@users.noreply.github.com>
Contributor
Author
|
Thanks @mrsabath — great catch on the supply-chain correctness. Blocking — fixed (2871873): removed the non-validating Non-blocking — confirmed: Also: applied the identical fix proactively to the operator's token-broker go.sum in #485 (same placeholder issue for Title nit: same as on #2230 — happy to switch to a word prefix; which form passes both the emoji |
Contributor
|
Blocked on Phase 0/1 of the rename rollout ordering (see rossoctl/rossoctl#1972). This PR unblocks once |
mrsabath
pushed a commit
that referenced
this pull request
Jul 20, 2026
…ortex Follow-up to the Rossoctl rename (#678 merged the kagenti→rossoctl content but not the later rossocortex→cortex change). The repo is now rossoctl/cortex, yet its 8 Go modules still declared github.com/rossoctl/rossocortex/... — a module-path mismatch that breaks `go get`/imports of github.com/rossoctl/cortex/... . Sweeps all rossocortex → cortex: - Go modules (8): github.com/rossoctl/rossocortex/... → github.com/rossoctl/cortex/... (+ internal replace directives) - Images: ghcr.io/rossoctl/rossocortex/* → ghcr.io/rossoctl/cortex/* - Brand/prose: RossoCortex/Rossocortex → Cortex Verification: grep clean of rossocortex and kagenti; authbridge-cpex + demos build. authlib/authbridge-envoy/authbridge-proxy still depend on github.com/rossoctl/ context-guru, which is org-moved but not yet module-path-renamed (its go.mod still declares github.com/kagenti/context-guru) — so `go mod tidy` there is blocked until context-guru itself is renamed + republished; real go.sum checksums regenerate then. Related to #1972 Assisted-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: IBRAHIM IBRAHIM <66755652+Ibrahim2595@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full content rename Kagenti → Rossoctl. Repo renamed kagenti-extensions → rossocortex; all 1582 case-insensitive
kagentireferences updated; grep is clean.Changes:
Verification:
replacethat authlib's own code compiles; resolves once context-guru is renamed + republished andgo mod tidyis re-run.Related to #1972
Assisted-By: Claude Opus 4.8 noreply@anthropic.com
Summary
Related issue(s)
(Optional) Testing Instructions
Fixes #