added empty sender plugin - #23
Open
chstout wants to merge 1 commit into
Open
Conversation
Owner
|
I guess it would make more sense to export nop yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wasn't sure if it'd be better to have a empty plugin, or to promote nop to be an exported variable (or if you don't like either of those options).
My use case is that I have a project that uses datadog once deployed to the cloud, and locally it uses influxdb through docker-compose. Environment variables passed into the container is what triggers which to use. An absence of any variable defaults to no instrumentation (in this case, the empty sender).