Skip to content

Stringex fix yaml reserved words - #200

Merged
rsl merged 2 commits into
rsl:masterfrom
giga811:stringex-fix-yaml-reserved-words
Mar 9, 2018
Merged

rsl merged 2 commits into
rsl:masterfrom
giga811:stringex-fix-yaml-reserved-words

Conversation

@giga811

@giga811 giga811 commented Mar 6, 2018

Copy link
Copy Markdown
Contributor

yes, no are converted into true, false in yaml (until 1.1).
(There was no documentation about this in 1.2)

Therefore these characters which has ascii decoding/pronounciation of yes, no are converted into string "true", "false".

irb(main):022:0> "ኖᏃᓄᖺᘃのノ㋨ꆌ노".to_url
=> "falsefalsefalsefalsefalsefalsefalsefalsefalsefalse"
irb(main):027:0> '온'.to_url
=> "true"

I wrapped all the yes, no occurrences with brackets.

@giga811

giga811 commented Mar 8, 2018

Copy link
Copy Markdown
Contributor Author

Hi @rsl , I am wondering if we should update original gem unidecode too. Or is it no longer supported?
http://www.rubydoc.info/gems/unidecode/1.0.0/frames

@rsl

rsl commented Mar 9, 2018

Copy link
Copy Markdown
Owner

@giga811 first, GREAT find. i remember a similar issue with true and false as words needing quotations in yml.

second, unidecode is just stringex internals now, yeah.

@rsl
rsl merged commit 6ace363 into rsl:master Mar 9, 2018
@rsl

rsl commented Mar 9, 2018

Copy link
Copy Markdown
Owner

released as 2.8.3

@giga811

giga811 commented Mar 12, 2018

Copy link
Copy Markdown
Contributor Author

Thanks for the update 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants