Avoid mutating SSLContext in SSLServer.#742
Closed
ioquatix wants to merge 1 commit into
Closed
Conversation
Member
|
Can we just skip assigning the session ID context if I agree |
rhenium
reviewed
Apr 26, 2024
| session_id = prng.bytes(16).unpack1('H*') | ||
| self.session_id_context = session_id | ||
| end | ||
|
|
Member
There was a problem hiding this comment.
SSLContext#set_params is useful only for TLS clients so the session ID context should not be set here (which only makes sense for servers).
rhenium
added a commit
to rhenium/ruby-openssl
that referenced
this pull request
Jun 24, 2026
Do not raise FrozenError in SSLServer.new when SSLContext#session_id_context cannot be updated. session_id_context is only necessary for session resumption, so its absence is not critical. Fixes ruby#742
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jun 24, 2026
Do not raise FrozenError in SSLServer.new when SSLContext#session_id_context cannot be updated. session_id_context is only necessary for session resumption, so its absence is not critical. Fixes ruby/openssl#742 ruby/openssl@51de9c303e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that we shouldn't mutate the
SSLContextinSSLServerand instead be more proactive about setting the right defaults.