Improve the GC harness Summary output#517
Merged
Merged
Conversation
peterzhu2118
approved these changes
Jun 18, 2026
peterzhu2118
left a comment
Member
There was a problem hiding this comment.
Nice, I really like this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more information about GC counts and timing to the summary output of the GC handler to avoid having to scroll up to the individual tables and infer information. It adds:
mean(total_control_time) / mean(total_experiment_time). Above 1 represents a speed-up in the experiment branch.mean(total_marking_time) / (mean(major_count) + mean(minor_count))1.4 -> 6.0says that the control branch ran an average of 1.4 GC cycles across all runs, and the experiment ran an average of 6.0.the
time / iterandtime / GCratios are intended to help determine whether the marking/sweeping time improved because marking/sweeping got faster, or because we're running fewer. For example, If "mark time/iter" improves but "mark time/GC" stays flat then you know that the win came from running fewer GC cycles.New Summary output looks like this: