Skip to content

do not mind excepction class - #170

Merged
nobu merged 1 commit into
ruby:masterfrom
nobu:bug/Date-minus_month-exception
Dec 8, 2015
Merged

do not mind excepction class#170
nobu merged 1 commit into
ruby:masterfrom
nobu:bug/Date-minus_month-exception

Conversation

@nobu

@nobu nobu commented Dec 8, 2015

Copy link
Copy Markdown
Member

It should be TypeError as other methods, but Date#<< misses
the check.

It should be `TypeError` as other methods, but `Date#<<` misses
the check.
nobu added a commit that referenced this pull request Dec 8, 2015
@nobu
nobu merged commit f8358bd into ruby:master Dec 8, 2015
@nobu
nobu deleted the bug/Date-minus_month-exception branch December 8, 2015 01:17
@eregon

eregon commented Dec 8, 2015

Copy link
Copy Markdown
Member

@nobu Is this going to be backported? It seems not.

@eregon

eregon commented Dec 8, 2015

Copy link
Copy Markdown
Member

@nobu In the case it's not backported, it's good to generalize as you did, but then also to test more precisely for the new version like I did in 72b2688.

@eregon eregon mentioned this pull request Dec 16, 2015
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants