Skip to content

DidYouMean specs for ruby 2.3 - #351

Merged
eregon merged 2 commits into
ruby:masterfrom
mjago:did_you_mean_spec
Nov 8, 2016
Merged

DidYouMean specs for ruby 2.3#351
eregon merged 2 commits into
ruby:masterfrom
mjago:did_you_mean_spec

Conversation

@mjago

@mjago mjago commented Nov 7, 2016

Copy link
Copy Markdown
Contributor

with reference to issue #175

@eregon

eregon commented Nov 8, 2016

Copy link
Copy Markdown
Member

Nice!
It's a bit strange that ruby trunk does not pass those specs, maybe an issue with Travis' MRI build?

@mjago

mjago commented Nov 8, 2016

Copy link
Copy Markdown
Contributor Author

@eregon Yes I thought the same - did_you_mean doesn't seem activated on travis trunk.
I briefly checked out did_you_mean gem's repo last night github and there may be some dependency issue regarding travis / trunk and a dependency of did_you_mean gem. I can look into it.
In the mean time it helps resolve the #175 issue with the current guard I guess?

@eregon

eregon commented Nov 8, 2016

Copy link
Copy Markdown
Member

@mjago It works locally for me on my ruby trunk, I think Travis uses RVM to package ruby-head and that seems the cause of the problem.
I am pondering whether we should just build ruby-trunk ourselves but that seems heavy for the CI.

@eregon

eregon commented Nov 8, 2016

Copy link
Copy Markdown
Member

You are right, we can merge this in the mean time until we figure it out for ruby-trunk.

Actually, I'm gladly surprised of the precision and extent of these specs, thanks for the great work @mjago!

@eregon
eregon merged commit a6edbbf into ruby:master Nov 8, 2016
@eregon eregon mentioned this pull request Nov 8, 2016
51 tasks
@mjago

mjago commented Nov 8, 2016

Copy link
Copy Markdown
Contributor Author

Yes just looked again - Yuki had a similar issue which I guess is related.

@mjago

mjago commented Nov 10, 2016

Copy link
Copy Markdown
Contributor Author

Added an issue ruby/chkbuild/issues/29 to chkbuild regarding this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants