Conversation
dron0gus
force-pushed
the
artery-dev-backport
branch
from
November 3, 2023 08:30
7a7eb9d to
421ff88
Compare
dron0gus
marked this pull request as ready for review
November 3, 2023 08:30
dron0gus
pushed a commit
to dron0gus/ChibiOS
that referenced
this pull request
Sep 4, 2026
…23 (backport to 21.11.6) (rusefi#39) 🤖 Sheriff-prepared backport, for human review/merge. Backport to **stable-21.11.x** (21.11.6) of github PR rusefi#34, merged on `main` as `31e09a9b`. **HAL-only** — 21.11.x has no XHAL port. On Cortex-M0/M0+/M23 `SCB->SHPR` is a word array driven through the CMSIS `_SHP_IDX()`/`_BIT_SHIFT()` macros, which expect the *negative* system exception number. `nvicSetSystemHandlerPriority()` passed the positive ChibiOS handler index (`HANDLER_SYSTICK = 11`, …), so the priority write hit the wrong SHPR slot — SysTick kept its reset priority (0, highest) and SVCall's was corrupted. Converted to the matching exception number (`handler - 12`). Affects every baseline-core port (RP2040, STM32C0/G0/L0, STM32WL, …). **Gates (local):** `RT-STM32L053…` (Cortex-M0+) builds clean; `stylecheck.py` clean on changed lines. Same fix as the HW-validated main change; HW re-confirmation on a baseline target is welcome but the code is identical to `main`. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
rusefillc
pushed a commit
that referenced
this pull request
Sep 21, 2026
…23 (backport to 21.11.6) (#39) 🤖 Sheriff-prepared backport, for human review/merge. Backport to **stable-21.11.x** (21.11.6) of github PR #34, merged on `main` as `31e09a9b`. **HAL-only** — 21.11.x has no XHAL port. On Cortex-M0/M0+/M23 `SCB->SHPR` is a word array driven through the CMSIS `_SHP_IDX()`/`_BIT_SHIFT()` macros, which expect the *negative* system exception number. `nvicSetSystemHandlerPriority()` passed the positive ChibiOS handler index (`HANDLER_SYSTICK = 11`, …), so the priority write hit the wrong SHPR slot — SysTick kept its reset priority (0, highest) and SVCall's was corrupted. Converted to the matching exception number (`handler - 12`). Affects every baseline-core port (RP2040, STM32C0/G0/L0, STM32WL, …). **Gates (local):** `RT-STM32L053…` (Cortex-M0+) builds clean; `stylecheck.py` clean on changed lines. Same fix as the HW-validated main change; HW re-confirmation on a baseline target is welcome but the code is identical to `main`. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.