Cleanup IOCTL definitions in linux_like tree - #4418
Merged
Merged
Conversation
Collaborator
jjanowsk
force-pushed
the
if_tun_ioctls_refactor
branch
2 times, most recently
from
April 15, 2025 15:29
d600ca5 to
ff04f46
Compare
jjanowsk
marked this pull request as ready for review
April 16, 2025 08:28
Collaborator
|
Some changes occurred in the Android module cc @maurer |
tgross35
approved these changes
Apr 25, 2025
tgross35
left a comment
Contributor
There was a problem hiding this comment.
Oh this is so nice, +179/-525 is a great diff. Thank you for putting this together!
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Apr 25, 2025
tgross35
force-pushed
the
if_tun_ioctls_refactor
branch
from
April 25, 2025 07:34
ff04f46 to
28d80ed
Compare
tgross35
requested changes
Apr 25, 2025
tgross35
left a comment
Contributor
There was a problem hiding this comment.
Sorry, looks like this needs to pick up a few recent additions that have merged since this was created. Would you be able to update this?
jjanowsk
force-pushed
the
if_tun_ioctls_refactor
branch
from
May 15, 2025 17:03
28d80ed to
49a6e23
Compare
Contributor
Author
|
@rustbot label -S-waiting-on-author +S-waiting-on-review |
Contributor
Author
|
@tgross35 Sorry, I've been busy lately. Here's the updated version. |
tgross35
approved these changes
May 15, 2025
tgross35
left a comment
Contributor
There was a problem hiding this comment.
Thank you for cleaning this up!
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 1, 2025
(backport <rust-lang#4418>) (cherry picked from commit 49a6e23)
tgross35
pushed a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 1, 2025
(backport <rust-lang#4418>) (cherry picked from commit 49a6e23)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cleanup IOCTL definitions in linux_like tree
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI