Skip to content

build: Implement Display trait for Cfg - #5493

Merged
tgross35 merged 1 commit into
rust-lang:mainfrom
xtqqczze:cfg-display
Sep 7, 2026
Merged

tgross35 merged 1 commit into
rust-lang:mainfrom
xtqqczze:cfg-display

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor

cc: @tgross35

@rustbot rustbot added S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Sep 6, 2026
@xtqqczze

xtqqczze commented Sep 6, 2026 •

Copy link
Copy Markdown
Contributor Author

There would be an easy way to implement this using strum crate, if we can take build dependencies?

#[derive(Clone, Copy, Debug, PartialEq, Eq, PartialOrd, Ord, strum::Display)]
#[strum(serialize_all = "snake_case")]
enum Cfg {
    ...
}

Comment thread build.rs
@tgross35

tgross35 commented Sep 7, 2026

Copy link
Copy Markdown
Member

There would be an easy way to implement this using strum crate, if we can take build dependencies?

No please, not worth it for ~20 lines of code

@rustbot

rustbot commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@tgross35 tgross35 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgross35
tgross35 enabled auto-merge September 7, 2026 18:51
@tgross35
tgross35 added this pull request to the merge queue Sep 7, 2026
Merged via the queue into rust-lang:main with commit 5cf8e76 Sep 7, 2026
113 of 115 checks passed
@xtqqczze
xtqqczze deleted the cfg-display branch September 7, 2026 19:23
@tgross35 tgross35 mentioned this pull request Sep 17, 2026
renovate-bot pushed a commit to renovate-bot/rust-lang-_-libc that referenced this pull request Sep 17, 2026
(backport <rust-lang#5493>)
(cherry picked from commit 5cf8e76)
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable-applied This PR has been cherry-picked to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants