build: Don't warn when enabling opting into musl 1.2 via multiple ways - #5517
Merged
Merged
Conversation
In Alpine, we have to set both the old and new `cfg` *and* the environment variable since various versions of libc are being used by packaged software. This will then emit the warnings about the options being deprecated, even though we fully intentionally set them. I believe the primary purpose of the warnings is to tell people to migrate to the new `cfg`, so we can just not print a warning if musl 1.2 is being opted into via a different way (and the `cfg` or env var has no effect) already.
Contributor
Author
|
@rustbot label +stable-nominated |
Merged
renovate-bot
pushed a commit
to renovate-bot/rust-lang-_-libc
that referenced
this pull request
Sep 17, 2026
In Alpine, we have to set both the old and new `cfg` *and* the environment variable since various versions of libc are being used by packaged software. This will then emit the warnings about the options being deprecated, even though we fully intentionally set them. I believe the primary purpose of the warnings is to tell people to migrate to the new `cfg`, so we can just not print a warning if musl 1.2 is being opted into via a different way (and the `cfg` or env var has no effect) already. (backport <rust-lang#5517>) (cherry picked from commit df65616)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Alpine, we have to set both the old and new
cfgand the environment variable since various versions of libc are being used by packaged software.This will then emit the warnings about the options being deprecated, even though we fully intentionally set them. I believe the primary purpose of the warnings is to tell people to migrate to the new
cfg, so we can just not print a warning if musl 1.2 is being opted into via a different way (and thecfgor env var has no effect) already.