Skip to content

Remove public visibility from old stat fields - #5542

Merged
tgross35 merged 1 commit into
rust-lang:mainfrom
xtqqczze:old-stat
Sep 29, 2026
Merged

tgross35 merged 1 commit into
rust-lang:mainfrom
xtqqczze:old-stat

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Remove public visibility from legacy stat/stat64 fields that are intended to be internal implementation details. They are already private in the corresponding layouts on other targets, so exposing them publicly is unnecessary and inconsistent.

@rustbot

rustbot commented Sep 25, 2026

Copy link
Copy Markdown
Collaborator

Error: Label stable-declined can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@tgross35 tgross35 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can backport since this only affects T3 targets.

View changes since this review

@tgross35 tgross35 added the stable-nominated This PR should be considered for cherry-pick to libc's stable release branch label Sep 29, 2026
@tgross35
tgross35 added this pull request to the merge queue Sep 29, 2026
Merged via the queue into rust-lang:main with commit ac187e7 Sep 29, 2026
61 checks passed
@xtqqczze
xtqqczze deleted the old-stat branch September 29, 2026 08:55
@tgross35 tgross35 mentioned this pull request Oct 1, 2026
renovate-bot pushed a commit to renovate-bot/rust-lang-_-libc that referenced this pull request Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-arm O-bsd O-dragonfly O-freebsd O-gnu O-linux O-linux-like O-unix stable-nominated This PR should be considered for cherry-pick to libc's stable release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants