Repository navigation
apple: add posix_spawn_file_actions_add(f)chdir(_np) - #5558
Merged
Merged
Conversation
This was referenced Sep 24, 2026
Contributor
Author
|
The NetBSD failure is unrelated to this PR: the package mirror failed, and the retry in |
tgross35
reviewed
Sep 29, 2026
Member
There was a problem hiding this comment.
@madsmtm we probably shouldn't add anything marked __SPI_AVAILABLE, right?
| fd: c_int, | ||
| newfd: c_int, | ||
| ) -> c_int; | ||
| // Available starting with macOS 10.15. |
Member
There was a problem hiding this comment.
We don't have these comments elsewhere, could you delete them?
Contributor
Author
There was a problem hiding this comment.
Deleted, thanks. I'll hold off on anything else until you and @madsmtm have settled the __SPI_AVAILABLE question.
Add the chdir file actions on macOS: the `_np` versions, available since macOS 10.15, and the POSIX.1-2024 names, available since macOS 26.0. On the other Apple platforms they are only SPI. Sources: https://github.com/apple-oss-distributions/xnu/blob/f6217f891ac0bb64f3d375211650a4c1ff8ca1ea/libsyscall/wrappers/spawn/spawn.h#L72-L76 https://github.com/apple-oss-distributions/xnu/blob/f6217f891ac0bb64f3d375211650a4c1ff8ca1ea/libsyscall/wrappers/spawn/spawn.h#L182-L186 Part of rust-lang#3958
xjtu-ctgg
force-pushed
the
apple-spawn-chdir
branch
from
September 29, 2026 03:09
3d48f1d to
13c4578
Compare
Member
Yes, we shouldn't, those are for Apple's embedded OSes IIUC. |
madsmtm
approved these changes
Oct 1, 2026
tgross35
approved these changes
Oct 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 1, 2026
Merged
renovate-bot
pushed a commit
to renovate-bot/rust-lang-_-libc
that referenced
this pull request
Oct 1, 2026
Add the chdir file actions on macOS: the `_np` versions, available since macOS 10.15, and the POSIX.1-2024 names, available since macOS 26.0. On the other Apple platforms they are only SPI. Sources: https://github.com/apple-oss-distributions/xnu/blob/f6217f891ac0bb64f3d375211650a4c1ff8ca1ea/libsyscall/wrappers/spawn/spawn.h#L72-L76 https://github.com/apple-oss-distributions/xnu/blob/f6217f891ac0bb64f3d375211650a4c1ff8ca1ea/libsyscall/wrappers/spawn/spawn.h#L182-L186 Part of rust-lang#3958 (backport <rust-lang#5558>) (cherry picked from commit 9e01c7f)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
posix_spawn_file_actions_addchdir_npandposix_spawn_file_actions_addfchdir_np, available since macOS 10.15, and the POSIX.1-2024posix_spawn_file_actions_addchdirandposix_spawn_file_actions_addfchdir, available since macOS 26.0.They are macOS only. The header marks them unavailable on the other Apple platforms, where XNU only has them as SPI.
The XNU source still says
macos(16.0)for the POSIX names, while the SDK header saysmacos(26.0), which is the version they shipped in.This is the Apple part of #3958.
Checklist
libc-test/semverhave been updated*LASTor*MAXhave the standard doc comment (none added)cargo test -p libc-test --target aarch64-apple-darwinwith the macOS 26.2 SDK, pluscargo checkforaarch64-apple-iosandx86_64-apple-darwin)@rustbot label +stable-nominated