Skip to content

Fix --no-default-features builds - #930

Merged
bors merged 7 commits into
rust-lang:masterfrom
gnzlbg:fix_musl
Feb 28, 2018
Merged

Fix --no-default-features builds#930
bors merged 7 commits into
rust-lang:masterfrom
gnzlbg:fix_musl

Conversation

@gnzlbg

@gnzlbg gnzlbg commented Feb 27, 2018

Copy link
Copy Markdown
Contributor

Closes #928 #929 #684

@rust-highfive

rust-highfive commented Feb 27, 2018

Copy link
Copy Markdown

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@gnzlbg

gnzlbg commented Feb 27, 2018

Copy link
Copy Markdown
Contributor Author

Is there a reason for the run.sh script to use exec to invoke cargo test on libc-test? ping: @malbarbo

@gnzlbg

gnzlbg commented Feb 27, 2018

Copy link
Copy Markdown
Contributor Author

The failure is not my fault. That target_vendor thing should probably have a #[cfg_attr] for libstd as well.

@alexcrichton

alexcrichton commented Feb 27, 2018

Copy link
Copy Markdown
Member

@gnzlbg for now could similar logic be applied to only take that branch when building in libstd?

@gnzlbg

gnzlbg commented Feb 28, 2018

Copy link
Copy Markdown
Contributor Author

@alexcrichton I've pushed a fix for that, hopefully that won't break anything else.

@alexcrichton

alexcrichton commented Feb 28, 2018

Copy link
Copy Markdown
Member

@bors: r+

@bors

bors commented Feb 28, 2018

Copy link
Copy Markdown
Contributor

📌 Commit 78320c7 has been approved by alexcrichton

@bors

bors commented Feb 28, 2018

Copy link
Copy Markdown
Contributor

⌛ Testing commit 78320c7 with merge 92d3739...

bors added a commit that referenced this pull request Feb 28, 2018
@bors
Auto merge of #930 - gnzlbg:fix_musl, r=alexcrichton
92d3739 
Fix --no-default-features builds

Closes #928 #929 #684
@bors

bors commented Feb 28, 2018

Copy link
Copy Markdown
Contributor

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 92d3739 to master...

@bors
bors merged commit 78320c7 into rust-lang:master Feb 28, 2018
This was referenced Feb 28, 2018
Closed
Closed
@clarfonthey

clarfonthey commented Mar 5, 2018

Copy link
Copy Markdown
Contributor

Could a new version of libc be released that includes this change?

@alexcrichton

alexcrichton commented Mar 5, 2018

Copy link
Copy Markdown
Member

Sure! Instructions for how to do so are here

@clarfonthey

clarfonthey commented Mar 5, 2018

Copy link
Copy Markdown
Contributor

@alexcrichton it appears that the version has already been bumped since the change, but it wasn't pushed to crates.io

@alexcrichton

alexcrichton commented Mar 5, 2018

Copy link
Copy Markdown
Member

Oops sorry about that, published now!

alexcrichton added a commit to alexcrichton/libc that referenced this pull request Jul 10, 2018
@alexcrichton
Fix a #[cfg] attribute
30bb481 
It looks like this was a mistake of rust-lang#930 but should be easy to fix!
@alexcrichton alexcrichton mentioned this pull request Jul 10, 2018
Merged
bors added a commit that referenced this pull request Jul 10, 2018
@bors
Auto merge of #1037 - alexcrichton:fix, r=alexcrichton
ab63550 
Fix a #[cfg] attribute

It looks like this was a mistake of #930 but should be easy to fix!
@Amanieu Amanieu mentioned this pull request Jul 12, 2018
Merged
bors added a commit that referenced this pull request Jul 12, 2018
@bors
Auto merge of #1038 - Amanieu:fix_netbsd, r=alexcrichton
5964896 
Fix netbsd build with "stdbuild"

A bug was introduced in #930 which caused netbsd to not link to libm.

r? @alexcrichton
bors added a commit that referenced this pull request Jul 12, 2018
@bors
Auto merge of #1038 - Amanieu:fix_netbsd, r=alexcrichton
bfe0e32 
Fix netbsd build with "stdbuild"

A bug was introduced in #930 which caused netbsd to not link to libm.

r? @alexcrichton
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichton alexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gnzlbg @rust-highfive @alexcrichton @bors @clarfonthey