Skip to content

feat: add replace_is_ok_with_if_let_ok assist - #15752

Merged
bors merged 2 commits into
rust-lang:masterfrom
Young-Flash:replace_is_method_with_if_let_method
Oct 13, 2023
Merged

feat: add replace_is_ok_with_if_let_ok assist#15752
bors merged 2 commits into
rust-lang:masterfrom
Young-Flash:replace_is_method_with_if_let_method

Conversation

@Young-Flash

@Young-Flash Young-Flash commented Oct 13, 2023

Copy link
Copy Markdown
Member

if_is_ok_assist

following #15743

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2023
Comment thread crates/ide-assists/src/lib.rs Outdated
@hkalbasi

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

📌 Commit 5bbca22 has been approved by HKalbasi

It is now in the queue for this repository.

@bors

bors commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

⌛ Testing commit 5bbca22 with merge 862693f...

@bors

bors commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-actions
Approved by: HKalbasi
Pushing 862693f to master...

@bors
bors merged commit 862693f into rust-lang:master Oct 13, 2023
@Young-Flash
Young-Flash deleted the replace_is_method_with_if_let_method branch October 13, 2023 08:37
bors added a commit that referenced this pull request Oct 15, 2023
fix: make cursor select at _tmp

Here make cursor select at `_tmp` atuomatically after the assist apply. Refer to [vscode snippet placeholder](https://code.visualstudio.com/docs/editor/userdefinedsnippets#_placeholders).

![cursor_selection](https://github.com/rust-lang/rust-analyzer/assets/71162630/a7866efe-2d54-488b-903e-9df039f34a7e)

following #15752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants