Skip to content

clean-up unnested_or_patterns - #15344

Merged
Jarcho merged 4 commits into
rust-lang:masterfrom
ada4a:cleanup-unnested-or-patterns
Nov 1, 2025
Merged

clean-up unnested_or_patterns#15344
Jarcho merged 4 commits into
rust-lang:masterfrom
ada4a:cleanup-unnested-or-patterns

Conversation

@ada4a

@ada4a ada4a commented Jul 25, 2025

Copy link
Copy Markdown
Contributor

misc stuff I found while working on #15343. Not sure about the P part, but the rest should be fine

changelog: none

@rustbot

rustbot commented Jul 25, 2025

Copy link
Copy Markdown
Collaborator

r? @Alexendoo

rustbot has assigned @Alexendoo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 25, 2025
Comment thread clippy_lints/src/unnested_or_patterns.rs Outdated
@ada4a
ada4a force-pushed the cleanup-unnested-or-patterns branch from 1eaa5e9 to dc58c53 Compare July 25, 2025 20:15
Comment thread clippy_lints/src/unnested_or_patterns.rs Outdated
@ada4a
ada4a force-pushed the cleanup-unnested-or-patterns branch from dc58c53 to de37b3a Compare July 26, 2025 07:31

@samueltardieu samueltardieu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove a few Box.

Comment thread clippy_lints/src/unnested_or_patterns.rs Outdated
Comment thread clippy_lints/src/unnested_or_patterns.rs Outdated
Comment thread clippy_lints/src/unnested_or_patterns.rs Outdated
Comment thread clippy_lints/src/unnested_or_patterns.rs Outdated
@ada4a

ada4a commented Jul 28, 2025

Copy link
Copy Markdown
Contributor Author

good catch! done

@ada4a
ada4a force-pushed the cleanup-unnested-or-patterns branch from 8ac40a1 to 91318cc Compare August 7, 2025 21:54
@ada4a

ada4a commented Aug 12, 2025

Copy link
Copy Markdown
Contributor Author

@Alexendoo friendly ping

@ada4a

ada4a commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

r? clippy

@rustbot rustbot assigned Jarcho and unassigned Alexendoo Aug 20, 2025
@rustbot

This comment has been minimized.

@ada4a
ada4a force-pushed the cleanup-unnested-or-patterns branch from 91318cc to 32e6170 Compare August 22, 2025 13:37
@ada4a

ada4a commented Oct 12, 2025

Copy link
Copy Markdown
Contributor Author

@Jarcho friendly ping

@ada4a
ada4a force-pushed the cleanup-unnested-or-patterns branch from 32e6170 to 5fdf011 Compare October 12, 2025 08:48
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@Jarcho Jarcho left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just needs to be rebased.

View changes since this review

@ada4a
ada4a force-pushed the cleanup-unnested-or-patterns branch from 5fdf011 to ba6eefc Compare October 16, 2025 20:03
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@ada4a
ada4a force-pushed the cleanup-unnested-or-patterns branch from ba6eefc to 44e3b16 Compare October 31, 2025 20:21
@rustbot

rustbot commented Oct 31, 2025

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@Jarcho
Jarcho added this pull request to the merge queue Nov 1, 2025
Merged via the queue into rust-lang:master with commit f51c555 Nov 1, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants