You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently tell people to use Weak to break cycles, but only provide two ways to do so, both unsavory: unsafe and RefCell. Additionally, there is nothing built into either of those mechanisms that prevents creating an Rc cycle. This PR fixes that.
Incidentally, I haven't seen any convincing uses for reference counted cycles, so I have no idea if this is the ideal API. However, it is definitely better than what is currently in place.
I believe that as-implemented this implementation will leak the FooInner structures if op fails. The weak reference count is 2, and there's only one actual weak reference anywhere, so when it gets destroyed via unwinding the reference count will drop to 1, not freeing the box. Certainly an problem which can be overcome, however! (make sure you add a test as well!)
This is probably obvious, but without using a RefCell somewhere, the cycle will be immutable. But this pattern might be useful for building persistent data structures with internal, cyclic aliasing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently tell people to use
Weakto break cycles, but only provide two ways to do so, both unsavory:unsafeandRefCell. Additionally, there is nothing built into either of those mechanisms that prevents creating anRccycle. This PR fixes that.Incidentally, I haven't seen any convincing uses for reference counted cycles, so I have no idea if this is the ideal API. However, it is definitely better than what is currently in place.