add a test for the getrandom fallback - #158125
Merged
Merged
Conversation
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
joboet
force-pushed
the
getrandom-fallback-test
branch
from
June 19, 2026 11:53
42bb07f to
ac3bada
Compare
Member
Author
|
r? libs |
Member
|
@bors r+ rollup |
Contributor
rust-timer
added a commit
that referenced
this pull request
Jun 20, 2026
Rollup merge of #158125 - joboet:getrandom-fallback-test, r=jhpratt add a test for the `getrandom` fallback Now that the randomness API is nearing stabilisation, I think it'd be quite good to have a test for our `getrandom` fallback code to rule out any issues with the polling logic. This test uses symbol interposition to control the `getrandom` return value; I tried to make it as resilient to changes to the `SystemRng`-internals as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the randomness API is nearing stabilisation, I think it'd be quite good to have a test for our
getrandomfallback code to rule out any issues with the polling logic. This test uses symbol interposition to control thegetrandomreturn value; I tried to make it as resilient to changes to theSystemRng-internals as possible.