Skip to content

fix: fix no resolution for self import in namespaced crates - #160518

Merged
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
JayanAXHF:fix/fix-ice-160512
Sep 9, 2026
Merged

fix: fix no resolution for self import in namespaced crates#160518
rust-bors[bot] merged 4 commits into
rust-lang:mainfrom
JayanAXHF:fix/fix-ice-160512

Conversation

@JayanAXHF

@JayanAXHF JayanAXHF commented Aug 4, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

closes #160512

Add a check for ident.name == kw::SelfLower in ModuleOrUniformRoot::OpenModule branch with correct Res

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 4, 2026
@rustbot

rustbot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

r? @folkertdev

rustbot has assigned @folkertdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 20 candidates

mu001999
mu001999 reviewed Aug 5, 2026
View reviewed changes
Comment thread tests/ui/resolve/namespaced-crate-self-import.rs Outdated
@folkertdev

folkertdev commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

r? petrochenkov

@rustbot rustbot assigned petrochenkov and unassigned folkertdev Aug 5, 2026
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 6, 2026
@rustbot

This comment has been minimized.

Sign in to view
@JayanAXHF

JayanAXHF commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 5, 2026
@rustbot

rustbot commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

petrochenkov
petrochenkov reviewed Sep 8, 2026
View reviewed changes
Comment thread compiler/rustc_resolve/src/ident.rs
Comment thread tests/ui/resolve/namespaced-crate-self-import.rs Outdated
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2026
@JayanAXHF

JayanAXHF commented Sep 9, 2026

Copy link
Copy Markdown
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 9, 2026
@petrochenkov

petrochenkov commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

📌 Commit e7f01f6 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 9, 2026
@jhpratt jhpratt mentioned this pull request Sep 9, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Sep 9, 2026
@bors
Auto merge of #162550 - jhpratt:rollup-Xr9XvcB, r=jhpratt
07d81ab 
Rollup of 8 pull requests

Successful merges:

 - #162412 (Fix msvc-specific differences in debuginfo tests)
 - #160651 (mir: validate `Move` call arguments are locals or box derefs)
 - #161946 (Generalise (most) impls on `Box`)
 - #162192 (normalize CoerceShared field types before relating)
 - #160518 (fix: fix no resolution for self import in namespaced crates)
 - #162509 (Avoid suggesting gated generic arguments for Fn-family traits)
 - #162521 (Don't explicitly specify `OnDuplicate::Error` as it is the default)
 - #162526 (yeet VisitorExt)
rust-bors Bot pushed a commit that referenced this pull request Sep 9, 2026
@bors
Auto merge of #162550 - jhpratt:rollup-Xr9XvcB, r=jhpratt
d0f637a 
Rollup of 8 pull requests

Successful merges:

 - #162412 (Fix msvc-specific differences in debuginfo tests)
 - #160651 (mir: validate `Move` call arguments are locals or box derefs)
 - #161946 (Generalise (most) impls on `Box`)
 - #162192 (normalize CoerceShared field types before relating)
 - #160518 (fix: fix no resolution for self import in namespaced crates)
 - #162509 (Avoid suggesting gated generic arguments for Fn-family traits)
 - #162521 (Don't explicitly specify `OnDuplicate::Error` as it is the default)
 - #162526 (yeet VisitorExt)
rust-bors Bot pushed a commit that referenced this pull request Sep 9, 2026
@bors
Auto merge of #162550 - jhpratt:rollup-Xr9XvcB, r=jhpratt
a36d05e 
Rollup of 8 pull requests

Successful merges:

 - #162412 (Fix msvc-specific differences in debuginfo tests)
 - #160651 (mir: validate `Move` call arguments are locals or box derefs)
 - #161946 (Generalise (most) impls on `Box`)
 - #162192 (normalize CoerceShared field types before relating)
 - #160518 (fix: fix no resolution for self import in namespaced crates)
 - #162509 (Avoid suggesting gated generic arguments for Fn-family traits)
 - #162521 (Don't explicitly specify `OnDuplicate::Error` as it is the default)
 - #162526 (yeet VisitorExt)
@rust-bors
rust-bors Bot merged commit d55ae5d into rust-lang:main Sep 9, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 9, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 9, 2026
@bors
Unrolled build for #160518 in rollup 162550
1751ea5 
Rollup merge of #160518 - JayanAXHF:fix/fix-ice-160512, r=petrochenkov

fix: fix no resolution for self import in namespaced crates

closes #160512

Add a check for `ident.name == kw::SelfLower` in `ModuleOrUniformRoot::OpenModule` branch with correct `Res`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petrochenkov petrochenkov petrochenkov left review comments
@mu001999 mu001999 mu001999 left review comments

Assignees

@petrochenkov petrochenkov

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

[ICE]: no resolution for an import

5 participants

@JayanAXHF @rustbot @folkertdev @petrochenkov @mu001999