Skip to content

Clean up some manual debug impls - #160644

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
mejrs:debug-impls
Aug 8, 2026
Merged

Clean up some manual debug impls#160644
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
mejrs:debug-impls

Conversation

@mejrs

@mejrs mejrs commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Some of these can just be derives. Others omitted fields, deliberately or not.

For example, the annotate emitter debug now looks like:

AnnotateSnippetEmitter {
    dst: <writer@0x9069b55c60>,
    sm: Some(
        SourceMap {
            files: RwLock(
                RwLock {
                    data: [
                        "C:\\Users\\bruno\\Rust\\rust\\tests\\ui\\consts\\bad-array-size-in-type-err.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/attribute_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/keyword_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/primitive_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\macros.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\thread\\local.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\prelude\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\prelude\\v1.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\clone.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\marker.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\default.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\cmp.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\drop.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\function.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\async_function.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\convert\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\double_ended.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\exact_size.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\collect.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\iterator.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\borrow.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\string.rs",
                    ],
                },
            ),
            file_loader: <file_loader@0x1f813386448>,
            path_mapping: FilePathMapping {
                mapping: [],
                filename_remapping_scopes: RemapPathScopeComponents(
                    MACRO | DIAGNOSTICS | DEBUGINFO | COVERAGE | DOCUMENTATION,
                ),
            },
            working_dir: RealFileName {
                local: Some(
                    InnerRealFileName {
                        name: "C:\\Users\\bruno\\Rust\\rust",
                        working_directory: "",
                        embeddable_name: "C:\\Users\\bruno\\Rust\\rust",
                    },
                ),
                maybe_remapped: InnerRealFileName {
                    name: "C:\\Users\\bruno\\Rust\\rust",
                    working_directory: "",
                    embeddable_name: "C:\\Users\\bruno\\Rust\\rust",
                },
                scopes: RemapPathScopeComponents(
                    0x0,
                ),
            },
            hash_kind: Sha256,
            checksum_hash_kind: None,
        },
    ),
    short_message: false,
    ui_testing: true,
    ignored_directories_in_source_blocks: [
        "C:\\Users\\bruno\\.cargo",
        "C:\\Users\\bruno\\Rust\\rust\\vendor",
    ],
    diagnostic_width: None,
    macro_backtrace: false,
    track_diagnostics: false,
    terminal_url: No,
    theme: Ascii,
}

@rustbot

rustbot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann, @JonathanBrouwer

rustc_errors::annotate_snippet_emitter_writer was changed

cc @Muscraft

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 6, 2026
@rustbot

rustbot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

r? @khyperia

rustbot has assigned @khyperia.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 16 candidates

@khyperia

khyperia commented Aug 7, 2026

Copy link
Copy Markdown
Member

heck yea

@bors r+ rollup

@rust-bors

rust-bors Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

📌 Commit b5c330c has been approved by khyperia

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 7, 2026
Clean up some manual debug impls

Some of these can just be derives. Others omitted fields, deliberately or not.

For example, the annotate emitter debug now looks like:
```rust
AnnotateSnippetEmitter {
    dst: <writer@0x9069b55c60>,
    sm: Some(
        SourceMap {
            files: RwLock(
                RwLock {
                    data: [
                        "C:\\Users\\bruno\\Rust\\rust\\tests\\ui\\consts\\bad-array-size-in-type-err.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/attribute_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/keyword_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/primitive_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\macros.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\thread\\local.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\prelude\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\prelude\\v1.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\clone.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\marker.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\default.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\cmp.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\drop.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\function.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\async_function.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\convert\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\double_ended.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\exact_size.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\collect.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\iterator.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\borrow.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\string.rs",
                    ],
                },
            ),
            file_loader: <file_loader@0x1f813386448>,
            path_mapping: FilePathMapping {
                mapping: [],
                filename_remapping_scopes: RemapPathScopeComponents(
                    MACRO | DIAGNOSTICS | DEBUGINFO | COVERAGE | DOCUMENTATION,
                ),
            },
            working_dir: RealFileName {
                local: Some(
                    InnerRealFileName {
                        name: "C:\\Users\\bruno\\Rust\\rust",
                        working_directory: "",
                        embeddable_name: "C:\\Users\\bruno\\Rust\\rust",
                    },
                ),
                maybe_remapped: InnerRealFileName {
                    name: "C:\\Users\\bruno\\Rust\\rust",
                    working_directory: "",
                    embeddable_name: "C:\\Users\\bruno\\Rust\\rust",
                },
                scopes: RemapPathScopeComponents(
                    0x0,
                ),
            },
            hash_kind: Sha256,
            checksum_hash_kind: None,
        },
    ),
    short_message: false,
    ui_testing: true,
    ignored_directories_in_source_blocks: [
        "C:\\Users\\bruno\\.cargo",
        "C:\\Users\\bruno\\Rust\\rust\\vendor",
    ],
    diagnostic_width: None,
    macro_backtrace: false,
    track_diagnostics: false,
    terminal_url: No,
    theme: Ascii,
}
```
rust-bors Bot pushed a commit that referenced this pull request Aug 7, 2026
…uwer

Rollup of 21 pull requests

Successful merges:

 - #159784 (Hint that memchr returns an in-bounds index)
 - #150885 (Revive L4Re target)
 - #159643 (Add support for splatted function pointers)
 - #160433 (delegation: add support for wrapping of the return value with `From::from`)
 - #160530 (refactor handling of target features in Session)
 - #160606 (bootstrap: Store and use an explicit CheckKind in `check::Rustc`)
 - #160628 (fix ICE in `suggest_add_reference_to_arg` for non-callable items)
 - #160634 (miri subtree update)
 - #157641 (Do not promote extern statics)
 - #158904 (Fix FutureDropPoll shim for by-move async closures)
 - #160103 (Add regression test for GAT bound mismatched type error)
 - #160335 (dlopen offload)
 - #160445 (codegen: classify localized MSVC linker progress as linker_info)
 - #160499 (rustc_resolve: move diagnostic attribute linting to attr parsing)
 - #160504 (cleanup borrowck, improve c-variadic handling)
 - #160577 (expand: Feature gate AST-based attribute macros on expressions and statements)
 - #160587 (Add regression test for associated type outlives bound at call site)
 - #160625 (platform-support/netbsd.md: No longer mention 8.x, due to EoL.)
 - #160636 (derive(Diagnostic): link to proper docs)
 - #160644 (Clean up some manual debug impls)
 - #160649 (move naked function ui tests)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 7, 2026
Clean up some manual debug impls

Some of these can just be derives. Others omitted fields, deliberately or not.

For example, the annotate emitter debug now looks like:
```rust
AnnotateSnippetEmitter {
    dst: <writer@0x9069b55c60>,
    sm: Some(
        SourceMap {
            files: RwLock(
                RwLock {
                    data: [
                        "C:\\Users\\bruno\\Rust\\rust\\tests\\ui\\consts\\bad-array-size-in-type-err.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/attribute_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/keyword_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/primitive_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\macros.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\thread\\local.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\prelude\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\prelude\\v1.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\clone.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\marker.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\default.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\cmp.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\drop.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\function.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\async_function.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\convert\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\double_ended.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\exact_size.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\collect.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\iterator.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\borrow.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\string.rs",
                    ],
                },
            ),
            file_loader: <file_loader@0x1f813386448>,
            path_mapping: FilePathMapping {
                mapping: [],
                filename_remapping_scopes: RemapPathScopeComponents(
                    MACRO | DIAGNOSTICS | DEBUGINFO | COVERAGE | DOCUMENTATION,
                ),
            },
            working_dir: RealFileName {
                local: Some(
                    InnerRealFileName {
                        name: "C:\\Users\\bruno\\Rust\\rust",
                        working_directory: "",
                        embeddable_name: "C:\\Users\\bruno\\Rust\\rust",
                    },
                ),
                maybe_remapped: InnerRealFileName {
                    name: "C:\\Users\\bruno\\Rust\\rust",
                    working_directory: "",
                    embeddable_name: "C:\\Users\\bruno\\Rust\\rust",
                },
                scopes: RemapPathScopeComponents(
                    0x0,
                ),
            },
            hash_kind: Sha256,
            checksum_hash_kind: None,
        },
    ),
    short_message: false,
    ui_testing: true,
    ignored_directories_in_source_blocks: [
        "C:\\Users\\bruno\\.cargo",
        "C:\\Users\\bruno\\Rust\\rust\\vendor",
    ],
    diagnostic_width: None,
    macro_backtrace: false,
    track_diagnostics: false,
    terminal_url: No,
    theme: Ascii,
}
```
rust-bors Bot pushed a commit that referenced this pull request Aug 7, 2026
…uwer

Rollup of 20 pull requests

Successful merges:

 - #159784 (Hint that memchr returns an in-bounds index)
 - #150885 (Revive L4Re target)
 - #159643 (Add support for splatted function pointers)
 - #160433 (delegation: add support for wrapping of the return value with `From::from`)
 - #160530 (refactor handling of target features in Session)
 - #160606 (bootstrap: Store and use an explicit CheckKind in `check::Rustc`)
 - #160628 (fix ICE in `suggest_add_reference_to_arg` for non-callable items)
 - #160634 (miri subtree update)
 - #157641 (Do not promote extern statics)
 - #158904 (Fix FutureDropPoll shim for by-move async closures)
 - #160103 (Add regression test for GAT bound mismatched type error)
 - #160335 (dlopen offload)
 - #160445 (codegen: classify localized MSVC linker progress as linker_info)
 - #160499 (rustc_resolve: move diagnostic attribute linting to attr parsing)
 - #160504 (cleanup borrowck, improve c-variadic handling)
 - #160577 (expand: Feature gate AST-based attribute macros on expressions and statements)
 - #160587 (Add regression test for associated type outlives bound at call site)
 - #160625 (platform-support/netbsd.md: No longer mention 8.x, due to EoL.)
 - #160636 (derive(Diagnostic): link to proper docs)
 - #160644 (Clean up some manual debug impls)
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 7, 2026
Clean up some manual debug impls

Some of these can just be derives. Others omitted fields, deliberately or not.

For example, the annotate emitter debug now looks like:
```rust
AnnotateSnippetEmitter {
    dst: <writer@0x9069b55c60>,
    sm: Some(
        SourceMap {
            files: RwLock(
                RwLock {
                    data: [
                        "C:\\Users\\bruno\\Rust\\rust\\tests\\ui\\consts\\bad-array-size-in-type-err.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/attribute_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/keyword_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/primitive_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\macros.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\thread\\local.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\prelude\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\prelude\\v1.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\clone.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\marker.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\default.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\cmp.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\drop.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\function.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\async_function.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\convert\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\double_ended.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\exact_size.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\collect.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\iterator.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\borrow.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\string.rs",
                    ],
                },
            ),
            file_loader: <file_loader@0x1f813386448>,
            path_mapping: FilePathMapping {
                mapping: [],
                filename_remapping_scopes: RemapPathScopeComponents(
                    MACRO | DIAGNOSTICS | DEBUGINFO | COVERAGE | DOCUMENTATION,
                ),
            },
            working_dir: RealFileName {
                local: Some(
                    InnerRealFileName {
                        name: "C:\\Users\\bruno\\Rust\\rust",
                        working_directory: "",
                        embeddable_name: "C:\\Users\\bruno\\Rust\\rust",
                    },
                ),
                maybe_remapped: InnerRealFileName {
                    name: "C:\\Users\\bruno\\Rust\\rust",
                    working_directory: "",
                    embeddable_name: "C:\\Users\\bruno\\Rust\\rust",
                },
                scopes: RemapPathScopeComponents(
                    0x0,
                ),
            },
            hash_kind: Sha256,
            checksum_hash_kind: None,
        },
    ),
    short_message: false,
    ui_testing: true,
    ignored_directories_in_source_blocks: [
        "C:\\Users\\bruno\\.cargo",
        "C:\\Users\\bruno\\Rust\\rust\\vendor",
    ],
    diagnostic_width: None,
    macro_backtrace: false,
    track_diagnostics: false,
    terminal_url: No,
    theme: Ascii,
}
```
rust-bors Bot pushed a commit that referenced this pull request Aug 7, 2026
…uwer

Rollup of 28 pull requests

Successful merges:

 - #159784 (Hint that memchr returns an in-bounds index)
 - #160673 (Improve `canonical_param_env_cache`)
 - #150885 (Revive L4Re target)
 - #159643 (Add support for splatted function pointers)
 - #160433 (delegation: add support for wrapping of the return value with `From::from`)
 - #160530 (refactor handling of target features in Session)
 - #160606 (bootstrap: Store and use an explicit CheckKind in `check::Rustc`)
 - #160628 (fix ICE in `suggest_add_reference_to_arg` for non-callable items)
 - #160683 (Add regression test for unknown feaeture name reported with other errors)
 - #157641 (Do not promote extern statics)
 - #158904 (Fix FutureDropPoll shim for by-move async closures)
 - #159816 (added note/help about iterator invalidation when mutating a collection inside a for loop)
 - #160103 (Add regression test for GAT bound mismatched type error)
 - #160335 (dlopen offload)
 - #160445 (codegen: classify localized MSVC linker progress as linker_info)
 - #160499 (rustc_resolve: move diagnostic attribute linting to attr parsing)
 - #160504 (cleanup borrowck, improve c-variadic handling)
 - #160577 (expand: Feature gate AST-based attribute macros on expressions and statements)
 - #160587 (Add regression test for associated type outlives bound at call site)
 - #160625 (platform-support/netbsd.md: No longer mention 8.x, due to EoL.)
 - #160633 (delegation: fix determining wrong `FnKind` when delegation is inside const arg)
 - #160636 (derive(Diagnostic): link to proper docs)
 - #160644 (Clean up some manual debug impls)
 - #160649 (move naked function ui tests)
 - #160672 (Improve `MaybeLiveLocals`)
 - #160693 (Add branch config for perf. unrolling in bors)
 - #160696 (rustc_codegen_llvm: handle sm_101* features being an alias)
 - #160706 (renovate: clarify that vulnerability PRs are opened automatically)
@rust-bors
rust-bors Bot merged commit 24780be into rust-lang:main Aug 8, 2026
@rustbot rustbot added this to the 1.99.0 milestone Aug 8, 2026
rust-timer added a commit that referenced this pull request Aug 8, 2026
Rollup merge of #160644 - mejrs:debug-impls, r=khyperia

Clean up some manual debug impls

Some of these can just be derives. Others omitted fields, deliberately or not.

For example, the annotate emitter debug now looks like:
```rust
AnnotateSnippetEmitter {
    dst: <writer@0x9069b55c60>,
    sm: Some(
        SourceMap {
            files: RwLock(
                RwLock {
                    data: [
                        "C:\\Users\\bruno\\Rust\\rust\\tests\\ui\\consts\\bad-array-size-in-type-err.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/attribute_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/keyword_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\../../core/src/primitive_docs.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\macros.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\thread\\local.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\prelude\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\std\\src\\prelude\\v1.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\clone.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\marker.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\default.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\cmp.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\drop.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\function.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\ops\\async_function.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\convert\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\mod.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\double_ended.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\exact_size.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\collect.rs",
                        "/rustc/FAKE_PREFIX\\library\\core\\src\\iter\\traits\\iterator.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\lib.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\borrow.rs",
                        "/rustc/FAKE_PREFIX\\library\\alloc\\src\\string.rs",
                    ],
                },
            ),
            file_loader: <file_loader@0x1f813386448>,
            path_mapping: FilePathMapping {
                mapping: [],
                filename_remapping_scopes: RemapPathScopeComponents(
                    MACRO | DIAGNOSTICS | DEBUGINFO | COVERAGE | DOCUMENTATION,
                ),
            },
            working_dir: RealFileName {
                local: Some(
                    InnerRealFileName {
                        name: "C:\\Users\\bruno\\Rust\\rust",
                        working_directory: "",
                        embeddable_name: "C:\\Users\\bruno\\Rust\\rust",
                    },
                ),
                maybe_remapped: InnerRealFileName {
                    name: "C:\\Users\\bruno\\Rust\\rust",
                    working_directory: "",
                    embeddable_name: "C:\\Users\\bruno\\Rust\\rust",
                },
                scopes: RemapPathScopeComponents(
                    0x0,
                ),
            },
            hash_kind: Sha256,
            checksum_hash_kind: None,
        },
    ),
    short_message: false,
    ui_testing: true,
    ignored_directories_in_source_blocks: [
        "C:\\Users\\bruno\\.cargo",
        "C:\\Users\\bruno\\Rust\\rust\\vendor",
    ],
    diagnostic_width: None,
    macro_backtrace: false,
    track_diagnostics: false,
    terminal_url: No,
    theme: Ascii,
}
```
pull Bot pushed a commit to LeeeeeeM/miri that referenced this pull request Aug 8, 2026
…uwer

Rollup of 28 pull requests

Successful merges:

 - rust-lang/rust#159784 (Hint that memchr returns an in-bounds index)
 - rust-lang/rust#160673 (Improve `canonical_param_env_cache`)
 - rust-lang/rust#150885 (Revive L4Re target)
 - rust-lang/rust#159643 (Add support for splatted function pointers)
 - rust-lang/rust#160433 (delegation: add support for wrapping of the return value with `From::from`)
 - rust-lang/rust#160530 (refactor handling of target features in Session)
 - rust-lang/rust#160606 (bootstrap: Store and use an explicit CheckKind in `check::Rustc`)
 - rust-lang/rust#160628 (fix ICE in `suggest_add_reference_to_arg` for non-callable items)
 - rust-lang/rust#160683 (Add regression test for unknown feaeture name reported with other errors)
 - rust-lang/rust#157641 (Do not promote extern statics)
 - rust-lang/rust#158904 (Fix FutureDropPoll shim for by-move async closures)
 - rust-lang/rust#159816 (added note/help about iterator invalidation when mutating a collection inside a for loop)
 - rust-lang/rust#160103 (Add regression test for GAT bound mismatched type error)
 - rust-lang/rust#160335 (dlopen offload)
 - rust-lang/rust#160445 (codegen: classify localized MSVC linker progress as linker_info)
 - rust-lang/rust#160499 (rustc_resolve: move diagnostic attribute linting to attr parsing)
 - rust-lang/rust#160504 (cleanup borrowck, improve c-variadic handling)
 - rust-lang/rust#160577 (expand: Feature gate AST-based attribute macros on expressions and statements)
 - rust-lang/rust#160587 (Add regression test for associated type outlives bound at call site)
 - rust-lang/rust#160625 (platform-support/netbsd.md: No longer mention 8.x, due to EoL.)
 - rust-lang/rust#160633 (delegation: fix determining wrong `FnKind` when delegation is inside const arg)
 - rust-lang/rust#160636 (derive(Diagnostic): link to proper docs)
 - rust-lang/rust#160644 (Clean up some manual debug impls)
 - rust-lang/rust#160649 (move naked function ui tests)
 - rust-lang/rust#160672 (Improve `MaybeLiveLocals`)
 - rust-lang/rust#160693 (Add branch config for perf. unrolling in bors)
 - rust-lang/rust#160696 (rustc_codegen_llvm: handle sm_101* features being an alias)
 - rust-lang/rust#160706 (renovate: clarify that vulnerability PRs are opened automatically)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants