Use recognizer functions for enums and tuple structs - #160791
Merged
Merged
Conversation
Collaborator
|
|
Member
|
Tested this on a simple user struct, looks to work fine. Let's try CI: @bors try jobs=aarch64-apple-1,aarch64-apple-2 |
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 10, 2026
Use recognizer functions for enums and tuple structs try-job: aarch64-apple-1 try-job: aarch64-apple-2
This comment has been minimized.
This comment has been minimized.
Contributor
Member
|
Ok, looks good, thank you! Let's try. @bors r+ |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 10, 2026
Use recognizer functions for enums and tuple structs Non-urgent, but related to rust-lang#160331 We currently shove most user defined types through `synthetic_lookup` as I hadn't gotten around to using type recognizers yet. If we want tests to skip outputting types when the type doesn't have a visualizer, we should also not attach a (useless) visualizer to most UDTs. The only things `synthetic_lookup` catches that aren't already caught by the regexes are tuple-structs and sum-type enums. This patch adds targeted type recognizers for those, and no longer sends types through `synthetic_lookup` at all on LLDB 19+ this doesn't affect `pretty-std.rs` since all those types have visualizers, but it will affect other tests if/when they're converted (e.g. `tests/debuginfo/struct-in-struct.rs`) r? @Kobzol, @jieyouxu
This was referenced Aug 10, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 10, 2026
…uwer Rollup of 9 pull requests Successful merges: - #158404 (trait_solver: normalize next-gen region constraints) - #160631 (Do not eagerly download rustfmt in bootstrap) - #160642 (mir: prohibit projection into scalable vec) - #160749 (MaybeDangling: ensure references fit inside the address space) - #160791 (Use recognizer functions for enums and tuple structs) - #160500 (Fix inaccurate description for crate and pathroot) - #160590 (Docs & bors: Replace mentions of libs-api with libs) - #160825 (Fix references to unsupported on sys::paths::unix) - #160852 (Use `remove_dir_all` for `./x clean`) Failed merges: - #160829 (bootstrap: Make `main.rs` a stub that calls into the library crate)
rust-timer
added a commit
that referenced
this pull request
Aug 10, 2026
Rollup merge of #160791 - Walnut356:enum_recog, r=Kobzol Use recognizer functions for enums and tuple structs Non-urgent, but related to #160331 We currently shove most user defined types through `synthetic_lookup` as I hadn't gotten around to using type recognizers yet. If we want tests to skip outputting types when the type doesn't have a visualizer, we should also not attach a (useless) visualizer to most UDTs. The only things `synthetic_lookup` catches that aren't already caught by the regexes are tuple-structs and sum-type enums. This patch adds targeted type recognizers for those, and no longer sends types through `synthetic_lookup` at all on LLDB 19+ this doesn't affect `pretty-std.rs` since all those types have visualizers, but it will affect other tests if/when they're converted (e.g. `tests/debuginfo/struct-in-struct.rs`) r? @Kobzol, @jieyouxu
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Aug 11, 2026
…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#158404 (trait_solver: normalize next-gen region constraints) - rust-lang/rust#160631 (Do not eagerly download rustfmt in bootstrap) - rust-lang/rust#160642 (mir: prohibit projection into scalable vec) - rust-lang/rust#160749 (MaybeDangling: ensure references fit inside the address space) - rust-lang/rust#160791 (Use recognizer functions for enums and tuple structs) - rust-lang/rust#160500 (Fix inaccurate description for crate and pathroot) - rust-lang/rust#160590 (Docs & bors: Replace mentions of libs-api with libs) - rust-lang/rust#160825 (Fix references to unsupported on sys::paths::unix) - rust-lang/rust#160852 (Use `remove_dir_all` for `./x clean`) Failed merges: - rust-lang/rust#160829 (bootstrap: Make `main.rs` a stub that calls into the library crate)
bjorn3
pushed a commit
to bjorn3/stdarch
that referenced
this pull request
Aug 13, 2026
…uwer Rollup of 9 pull requests Successful merges: - rust-lang/rust#158404 (trait_solver: normalize next-gen region constraints) - rust-lang/rust#160631 (Do not eagerly download rustfmt in bootstrap) - rust-lang/rust#160642 (mir: prohibit projection into scalable vec) - rust-lang/rust#160749 (MaybeDangling: ensure references fit inside the address space) - rust-lang/rust#160791 (Use recognizer functions for enums and tuple structs) - rust-lang/rust#160500 (Fix inaccurate description for crate and pathroot) - rust-lang/rust#160590 (Docs & bors: Replace mentions of libs-api with libs) - rust-lang/rust#160825 (Fix references to unsupported on sys::paths::unix) - rust-lang/rust#160852 (Use `remove_dir_all` for `./x clean`) Failed merges: - rust-lang/rust#160829 (bootstrap: Make `main.rs` a stub that calls into the library crate)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-urgent, but related to #160331
We currently shove most user defined types through
synthetic_lookupas I hadn't gotten around to using type recognizers yet. If we want tests to skip outputting types when the type doesn't have a visualizer, we should also not attach a (useless) visualizer to most UDTs.The only things
synthetic_lookupcatches that aren't already caught by the regexes are tuple-structs and sum-type enums. This patch adds targeted type recognizers for those, and no longer sends types throughsynthetic_lookupat all on LLDB 19+this doesn't affect
pretty-std.rssince all those types have visualizers, but it will affect other tests if/when they're converted (e.g.tests/debuginfo/struct-in-struct.rs)r? @Kobzol, @jieyouxu