Add regression test for generic inference - #161052
Merged
Merged
Conversation
Collaborator
|
rustbot has assigned @dingxiangfei2009. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Contributor
|
@rustbot r+ rollup=always |
Contributor
|
Thank you for your contribution! 🙇 |
Contributor
|
@bors r+ rollup=always |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 26, 2026
…2009 Add regression test for generic inference Fixes rust-lang#120922. This PR tests the crash mentioned in the issue. The reduction was made with `treereduce` and it was quite drastic. This code causes the same ICE as rust-lang#120922 on 1.76, 1.77 and 1.78. 1.79 appears to fix it, and it doesn't cause ICE on stable either. I couldn't figure out a good name for the test file so I just used the issue since there were others already doing that. But I could change it if there's a better name for it. EDIT: I saw that tidy didn't like the test name, so I changed it to please it. But like I said, I couldn't think of a good name, so I'm open to suggestions.
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 26, 2026
…uwer Rollup of 4 pull requests Successful merges: - #160651 (mir: validate `Move` call arguments are locals or box derefs) - #161736 (Tidy: show todo reason when lint fails (and fix the lint's tidy allow statement which was weird and broken...)) - #161052 (Add regression test for generic inference) - #161818 (Fix long type on diagnostics for conditionally implemented traits)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 26, 2026
Rollup of 5 pull requests Successful merges: - #159502 (Enhance suggestions for unresolved links with typos path) - #161052 (Add regression test for generic inference) - #161210 (Improve missing extern crate diagnostics in Rust 2015) - #161818 (Fix long type on diagnostics for conditionally implemented traits) - #161839 (Fix doc link to pointer::addr)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 27, 2026
Rollup merge of #161052 - lsunsi:issue120922, r=dingxiangfei2009 Add regression test for generic inference Fixes #120922. This PR tests the crash mentioned in the issue. The reduction was made with `treereduce` and it was quite drastic. This code causes the same ICE as #120922 on 1.76, 1.77 and 1.78. 1.79 appears to fix it, and it doesn't cause ICE on stable either. I couldn't figure out a good name for the test file so I just used the issue since there were others already doing that. But I could change it if there's a better name for it. EDIT: I saw that tidy didn't like the test name, so I changed it to please it. But like I said, I couldn't think of a good name, so I'm open to suggestions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #120922.
This PR tests the crash mentioned in the issue. The reduction was made with
treereduceand it was quite drastic.This code causes the same ICE as #120922 on 1.76, 1.77 and 1.78.
1.79 appears to fix it, and it doesn't cause ICE on stable either.
I couldn't figure out a good name for the test file so I just used the issue since there were others already doing that. But I could change it if there's a better name for it.
EDIT: I saw that tidy didn't like the test name, so I changed it to please it. But like I said, I couldn't think of a good name, so I'm open to suggestions.