Add #[track_caller] to signed integer div/rem methods - #161607
Merged
rust-bors[bot] merged 1 commit intoSep 6, 2026
Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @Mark-Simulacrum (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
kiana1kaslana
force-pushed
the
track-caller-signed-div
branch
from
August 23, 2026 15:56
589cdb5 to
bfdeee0
Compare
This comment has been minimized.
This comment has been minimized.
The unsigned counterparts got the attribute in #724fe8f, but the signed side was missed, so panics like `0i32.wrapping_div(0)` point at the library source instead of the caller. Also covers overflowing_div_euclid, which the issue missed but wrapping_div_euclid delegates to, so it would still report the wrong location without it.
kiana1kaslana
force-pushed
the
track-caller-signed-div
branch
from
August 24, 2026 03:00
bfdeee0 to
e4204a1
Compare
Member
Did you mean something else here? Looks like something tried to use a hex color code instead of an issue/PR number? |
Member
|
r=me with that fixed |
Author
|
that was a commit short hash for the previous track_caller |
Member
|
@bors r+ |
Contributor
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 5, 2026
…-Simulacrum Add #[track_caller] to signed integer div/rem methods Fixes #139672 The unsigned div/rem methods got #[track_caller] in 724fe8f but the signed side was missed. This adds it to the 8 signed methods listed in the issue, including overflowing_div_euclid which the issue missed but wrapping_div_euclid delegates to. No test added, matching the unsigned side. cg_gcc doesn't propagate track_caller through inlined div/rem yet so a runtime check would fail on the gcc-core-tests CI job.
Contributor
|
💔 Test for 6675d95 failed: CI. Failed job:
|
Author
|
@bors retry |
Contributor
|
@kiana1kaslana: 🔑 Insufficient privileges: not in review users |
Author
|
@Mark-Simulacrum the i686-msvc-2 job failed with "The hosted runner lost communication with the server", and a few other jobs were cancelled at the same time. I don't have bors privileges, so could you @bors retry when you have a moment? The code itself shouldn't be related — it's just a #[track_caller] addition on signed div/rem methods. |
Contributor
|
@kiana1kaslana: 🔑 Insufficient privileges: not in review users |
Member
|
@bors retry |
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 6, 2026
…uwer Rollup of 4 pull requests Successful merges: - #162032 (remove more trivial regions in evaluate_added_goals_and_make_canonical_response) - #161607 (Add #[track_caller] to signed integer div/rem methods) - #162339 (Revert "bootstrap: Enable rustdoc mergeable CCI for std and internal docs #161716") - #162158 (Revise documentation of `NumBuffer` and `format_into()`.)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 6, 2026
Rollup merge of #161607 - kiana1kaslana:track-caller-signed-div, r=Mark-Simulacrum Add #[track_caller] to signed integer div/rem methods Fixes #139672 The unsigned div/rem methods got #[track_caller] in 724fe8f but the signed side was missed. This adds it to the 8 signed methods listed in the issue, including overflowing_div_euclid which the issue missed but wrapping_div_euclid delegates to. No test added, matching the unsigned side. cg_gcc doesn't propagate track_caller through inlined div/rem yet so a runtime check would fail on the gcc-core-tests CI job.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #139672
The unsigned div/rem methods got #[track_caller] in 724fe8f but
the signed side was missed. This adds it to the 8 signed methods
listed in the issue, including overflowing_div_euclid which the
issue missed but wrapping_div_euclid delegates to.
No test added, matching the unsigned side. cg_gcc doesn't
propagate track_caller through inlined div/rem yet so a runtime
check would fail on the gcc-core-tests CI job.