Skip to content

run extern "tail" with byval argument test - #161912

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
folkertdev:extern-tail-x86-byval
Sep 8, 2026
Merged

run extern "tail" with byval argument test#161912
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
folkertdev:extern-tail-x86-byval

Conversation

@folkertdev

@folkertdev folkertdev commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

With LLVM 23 we can run extern "tail" tests with byval arguments on x86 and x86_64. AArch64 does not (yet) support this, see llvm/llvm-project#206718.

@folkertdev folkertdev added F-explicit_tail_calls `#![feature(explicit_tail_calls)]` F-rust_tail_cc `#![feature(rust_tail_cc)]` labels Aug 28, 2026
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 28, 2026
@rustbot

rustbot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

r? @mu001999

rustbot has assigned @mu001999.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 19 candidates

@folkertdev

folkertdev commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

r? WaffleLapkin

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-*,arm-android

@rustbot rustbot assigned WaffleLapkin and unassigned mu001999 Aug 28, 2026
@rustbot

rustbot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

WaffleLapkin is not on the review rotation at the moment.
They may take a while to respond.

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 28, 2026
@bors
Auto merge of #161912 - folkertdev:extern-tail-x86-byval, r=<try>
db4a9b6 
run `extern "tail"` with `byval` argument test


try-job: test-various
try-job: aarch64-apple-*
try-job: *-gnu-nopt-*
try-job: x86_64-mingw-*
try-job: aarch64-msvc-*
try-job: arm-android
@folkertdev folkertdev mentioned this pull request Aug 28, 2026
Open
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 28, 2026
@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

💔 Test for db4a9b6 failed: CI. Failed job:

@folkertdev
folkertdev force-pushed the extern-tail-x86-byval branch from 591b0a4 to 84963f8 Compare August 28, 2026 14:06
@rustbot

rustbot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@folkertdev

folkertdev commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

@bors try jobs=test-various,aarch64-apple-,-gnu-nopt-,x86_64-mingw-,aarch64-msvc-*,arm-android

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors Bot pushed a commit that referenced this pull request Aug 28, 2026
@bors
Auto merge of #161912 - folkertdev:extern-tail-x86-byval, r=<try>
1bb091f 
run `extern "tail"` with `byval` argument test


try-job: test-various
try-job: aarch64-apple-*
try-job: *-gnu-nopt-*
try-job: x86_64-mingw-*
try-job: aarch64-msvc-*
try-job: arm-android
@rust-bors

rust-bors Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 1bb091f (1bb091fe9288e793025eee71bc7ce621bdd4f127)
Base parent: c42ac5f (c42ac5fd59628ea7e2f52af5944c2aaac3f0e7f6)

@folkertdev

folkertdev commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

Sadly tailcc on windows x86_64 also does not work.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 28, 2026
WaffleLapkin
WaffleLapkin approved these changes Sep 8, 2026
View reviewed changes

@WaffleLapkin WaffleLapkin left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bors r+

View changes since this review

@rust-bors

rust-bors Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 84963f8 has been approved by WaffleLapkin

It is now in the queue for this repository.

@rust-bors rust-bors Bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 8, 2026
@rust-bors rust-bors Bot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 8, 2026
@WaffleLapkin

WaffleLapkin commented Sep 8, 2026

Copy link
Copy Markdown
Member

@bors rollup

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 8, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161912 - folkertdev:extern-tail-x86-byval, …
f1d7396 
…r=WaffleLapkin

run `extern "tail"` with `byval` argument test

With LLVM 23 we can run `extern "tail"` tests with `byval` arguments on x86 and x86_64. AArch64 does not (yet) support this, see llvm/llvm-project#206718.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 8, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 8, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161912 - folkertdev:extern-tail-x86-byval, …
679fb69 
…r=WaffleLapkin

run `extern "tail"` with `byval` argument test

With LLVM 23 we can run `extern "tail"` tests with `byval` arguments on x86 and x86_64. AArch64 does not (yet) support this, see llvm/llvm-project#206718.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 8, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
@bors
Auto merge of #162466 - JonathanBrouwer:rollup-jTvOTgI, r=JonathanBro…
4a5cde2 
…uwer

Rollup of 8 pull requests

Successful merges:

 - #160505 (delegation: supporting inherent impls)
 - #160651 (mir: validate `Move` call arguments are locals or box derefs)
 - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`)
 - #161912 (run `extern "tail"` with `byval` argument test)
 - #162435 (windows-gnu: document libgcc requirement)
 - #162439 (Update books)
 - #162459 (docs(time): replace "method" with "function")
 - #162465 (Fix my duplicate thanks entry)
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
@bors
Auto merge of #162466 - JonathanBrouwer:rollup-jTvOTgI, r=JonathanBro…
3e16dc5 
…uwer

Rollup of 8 pull requests

Successful merges:

 - #160505 (delegation: supporting inherent impls)
 - #160651 (mir: validate `Move` call arguments are locals or box derefs)
 - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`)
 - #161912 (run `extern "tail"` with `byval` argument test)
 - #162435 (windows-gnu: document libgcc requirement)
 - #162439 (Update books)
 - #162459 (docs(time): replace "method" with "function")
 - #162465 (Fix my duplicate thanks entry)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 8, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161912 - folkertdev:extern-tail-x86-byval, …
7c3d1c2 
…r=WaffleLapkin

run `extern "tail"` with `byval` argument test

With LLVM 23 we can run `extern "tail"` tests with `byval` arguments on x86 and x86_64. AArch64 does not (yet) support this, see llvm/llvm-project#206718.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 8, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
@bors
Auto merge of #162472 - JonathanBrouwer:rollup-Cn5Tu3a, r=JonathanBro…
f517d84 
…uwer

Rollup of 10 pull requests

Successful merges:

 - #162470 (Subtree sync for rustc_codegen_cranelift)
 - #160505 (delegation: supporting inherent impls)
 - #160651 (mir: validate `Move` call arguments are locals or box derefs)
 - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`)
 - #161912 (run `extern "tail"` with `byval` argument test)
 - #162435 (windows-gnu: document libgcc requirement)
 - #162439 (Update books)
 - #162451 (Add regression test for item-local diagnostic attribute lint levels)
 - #162459 (docs(time): replace "method" with "function")
 - #162465 (Fix my duplicate thanks entry)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 8, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161912 - folkertdev:extern-tail-x86-byval, …
c346c2d 
…r=WaffleLapkin

run `extern "tail"` with `byval` argument test

With LLVM 23 we can run `extern "tail"` tests with `byval` arguments on x86 and x86_64. AArch64 does not (yet) support this, see llvm/llvm-project#206718.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 8, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
@bors
Auto merge of #162474 - JonathanBrouwer:rollup-YRdMtmD, r=JonathanBro…
6a6ba35 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #160505 (delegation: supporting inherent impls)
 - #160651 (mir: validate `Move` call arguments are locals or box derefs)
 - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`)
 - #161912 (run `extern "tail"` with `byval` argument test)
 - #162435 (windows-gnu: document libgcc requirement)
 - #162439 (Update books)
 - #162451 (Add regression test for item-local diagnostic attribute lint levels)
 - #162459 (docs(time): replace "method" with "function")
 - #162465 (Fix my duplicate thanks entry)
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
@bors
Auto merge of #162474 - JonathanBrouwer:rollup-YRdMtmD, r=JonathanBro…
8c107de 
…uwer

Rollup of 9 pull requests

Successful merges:

 - #160505 (delegation: supporting inherent impls)
 - #160651 (mir: validate `Move` call arguments are locals or box derefs)
 - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`)
 - #161912 (run `extern "tail"` with `byval` argument test)
 - #162435 (windows-gnu: document libgcc requirement)
 - #162439 (Update books)
 - #162451 (Add regression test for item-local diagnostic attribute lint levels)
 - #162459 (docs(time): replace "method" with "function")
 - #162465 (Fix my duplicate thanks entry)
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 8, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
@bors
Auto merge of #162477 - JonathanBrouwer:rollup-xvTdfDi, r=JonathanBro…
b505807 
…uwer

Rollup of 12 pull requests

Successful merges:

 - #162462 (Fix unsoundness in `VecDeque::from_iter(vec::IntoIter)`)
 - #162468 (mir_build: Rename `lower_let_expr` to `lower_fallible_let`, and clarify)
 - #161806 (Add tests and docs for `#[derive(GenericTypeVisitable)]`)
 - #161912 (run `extern "tail"` with `byval` argument test)
 - #161932 (Only check `#[allow(dead_code)]` on the trait)
 - #162236 (Call renumberMetadataForAssembly() in LLVMRustPrintModule())
 - #162435 (windows-gnu: document libgcc requirement)
 - #162439 (Update books)
 - #162451 (Add regression test for item-local diagnostic attribute lint levels)
 - #162455 (Update codegen-llvm/inline-debuginfo.rs for distinct DILocation)
 - #162459 (docs(time): replace "method" with "function")
 - #162465 (Fix my duplicate thanks entry)
@rust-bors
rust-bors Bot merged commit 432a619 into rust-lang:main Sep 8, 2026
14 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 8, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
@bors
Unrolled build for #161912 in rollup 162477
6be0ce1 
Rollup merge of #161912 - folkertdev:extern-tail-x86-byval, r=WaffleLapkin

run `extern "tail"` with `byval` argument test

With LLVM 23 we can run `extern "tail"` tests with `byval` arguments on x86 and x86_64. AArch64 does not (yet) support this, see llvm/llvm-project#206718.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WaffleLapkin WaffleLapkin WaffleLapkin approved these changes

Assignees

@WaffleLapkin WaffleLapkin

Labels

F-explicit_tail_calls `#![feature(explicit_tail_calls)]` F-rust_tail_cc `#![feature(rust_tail_cc)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

5 participants

@folkertdev @rustbot @rust-log-analyzer @WaffleLapkin @mu001999