Skip to content

Diverse offload fixes - #161968

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
Sa4dUs:offload-fix
Sep 1, 2026
Merged

Diverse offload fixes#161968
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
Sa4dUs:offload-fix

Conversation

@Sa4dUs

@Sa4dUs Sa4dUs commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

HostMetadata pass skips linking. Now, offload_kernel macro lowers to core instead of std.

closes: #161703

r? @ZuseZ4

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 29, 2026
Sa4dUs
Sa4dUs commented Aug 29, 2026
View reviewed changes
Comment thread compiler/rustc_builtin_macros/src/offload.rs
ecx.path_global(
span,
[sym::std, sym::unimplemented].map(|s| Ident::new(s, span)).to_vec(),
[sym::core, sym::unimplemented].map(|s| Ident::new(s, span)).to_vec(),

@Sa4dUs Sa4dUs Aug 29, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not necessary if we compile the host with std, but ig it's still better to use core

View changes since the review

@ZuseZ4 ZuseZ4 Aug 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, there isn't really a reason to prevent offload to work in no-std code.

@Sa4dUs
Sa4dUs marked this pull request as ready for review August 29, 2026 12:02
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 29, 2026
@rustbot

This comment has been minimized.

Sign in to view
@ZuseZ4 ZuseZ4 changed the title Some offload fixes re #161703 Diverse offload fixes Aug 31, 2026
@ZuseZ4

ZuseZ4 commented Aug 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Confirmed to work on a server.
Since we now have two offload run-make tests, can you add a commit to move both into a new folder under run-make/offload, like we have it for autodiff? Also, please update the title or pr description to mention no-std support and the linker skipping for the first step, I just changed it to remove the linking from the title. After that
@bors delegate

@rust-bors

rust-bors Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

✌️ @Sa4dUs, you can now approve this pull request!

If @ZuseZ4 told you to "r=me" after making some further change, then please make that change and post @bors r=ZuseZ4.

View changes since this delegation.

@Sa4dUs

Sa4dUs commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

@bors r=ZuseZ4

@rust-bors

rust-bors Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 5698c8d has been approved by ZuseZ4

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 1, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161968 - Sa4dUs:offload-fix, r=ZuseZ4
7100dc3 
Diverse offload fixes

`HostMetadata` pass skips linking. Now, `offload_kernel` macro lowers to `core` instead of `std`.

closes: rust-lang#161703

r? @ZuseZ4
@JonathanBrouwer JonathanBrouwer mentioned this pull request Sep 1, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 1, 2026
@JonathanBrouwer
Rollup merge of rust-lang#161968 - Sa4dUs:offload-fix, r=ZuseZ4
1c83ec2 
Diverse offload fixes

`HostMetadata` pass skips linking. Now, `offload_kernel` macro lowers to `core` instead of `std`.

closes: rust-lang#161703

r? @ZuseZ4
This was referenced Sep 1, 2026
Closed
Merged
rust-bors Bot pushed a commit that referenced this pull request Sep 1, 2026
@bors
Auto merge of #162148 - JonathanBrouwer:rollup-Be980n8, r=JonathanBro…
5db7f4b 
…uwer

Rollup of 11 pull requests

Successful merges:

 - #151618 (rustdoc: add `--print` option)
 - #161287 (Update `icu_list` dependency to 2.3)
 - #161767 (change DEFAULT_STACK_SIZE to be 32MB on s390x)
 - #161968 (Diverse offload fixes)
 - #161971 (Remove -Zsaturating-float-casts flag)
 - #162071 (Fix ICE of getting item name from RPITIT)
 - #161209 (Rework `next_power_of_two` to always be `1 << …`)
 - #162073 (Change some `Infallible` to `!` in std)
 - #162086 (Remove `gate_check` from `AttributeStability::Unstable`)
 - #162102 (`alloc` crate: shrink undocumented `unsafe` blocks)
 - #162110 (make it clear that Range cannot represent arbitrary ranges)
@rust-bors
rust-bors Bot merged commit fc17dba into rust-lang:main Sep 1, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 1, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 1, 2026
@bors
Unrolled build for #161968 in rollup 162148
d5eefde 
Rollup merge of #161968 - Sa4dUs:offload-fix, r=ZuseZ4

Diverse offload fixes

`HostMetadata` pass skips linking. Now, `offload_kernel` macro lowers to `core` instead of `std`.

closes: #161703

r? @ZuseZ4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZuseZ4 ZuseZ4 ZuseZ4 left review comments

Assignees

@ZuseZ4 ZuseZ4

Labels

A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

Outdated std::offload example

3 participants

@Sa4dUs @rustbot @ZuseZ4