Implement `Rng` for `Box` - #162212

Merged

rust-bors[bot] merged 1 commit into

rust-lang:mainfrom

a1phyr:box_random

Sep 5, 2026

a1phyr commented Sep 2, 2026

Contributor

Tracking issue: #130703

Like #159435, this implementation must be implemented before the stabilization of Rng.

r? @joshtriplett

rustbot assigned joshtriplett

rustbot added S-waiting-on-review T-libs labels

rustbot commented Sep 2, 2026

Collaborator

joshtriplett is not on the review rotation at the moment.
They may take a while to respond.

a1phyr mentioned this pull request

Stabilize Rng and SystemRng #157168

Open

This comment has been minimized.

Sign in to view


          Implement Rng for Box

aea90f1

a1phyr force-pushed the box_random branch from 5a6cd78 to aea90f1 Compare

September 3, 2026 18:02

rustbot commented Sep 3, 2026

Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

joboet commented Sep 4, 2026

Member

I'm going to go out on a limb and approve this, this seems entirely uncontroversial.

@bors r+ rollup

rust-bors Bot commented Sep 4, 2026

Contributor

📌 Commit aea90f1 has been approved by joboet

It is now in the queue for this repository.

rust-bors Bot added S-waiting-on-bors and removed S-waiting-on-review labels

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request


          Rollup merge of rust-lang#162212 - a1phyr:box_random, r=joboet

dfa491a

Implement `Rng` for `Box`

Tracking issue: rust-lang#130703

Like rust-lang#159435, this implementation must be implemented before the stabilization of `Rng`.

r? @joshtriplett

JonathanBrouwer mentioned this pull request

Rollup of 13 pull requests #162293

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request


          Rollup merge of rust-lang#162212 - a1phyr:box_random, r=joboet

62e687c

Implement `Rng` for `Box`

Tracking issue: rust-lang#130703

Like rust-lang#159435, this implementation must be implemented before the stabilization of `Rng`.

r? @joshtriplett

GuillaumeGomez mentioned this pull request

Rollup of 25 pull requests #162297

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request


          Rollup merge of rust-lang#162212 - a1phyr:box_random, r=joboet

8ff6e79

Implement `Rng` for `Box`

Tracking issue: rust-lang#130703

Like rust-lang#159435, this implementation must be implemented before the stabilization of `Rng`.

r? @joshtriplett

GuillaumeGomez mentioned this pull request

Rollup of 25 pull requests #162298

Closed

rust-bors Bot pushed a commit that referenced this pull request


          Auto merge of #162298 - GuillaumeGomez:rollup-LXW43Ox, r=GuillaumeGomez

cce0553

Rollup of 25 pull requests

Successful merges:

 - #159074 ([PAC] FnAbi, llvm.ptrauth.resign and Session API change (2/8))
 - #159792 (A more readable debug map for IndexMaps)
 - #161895 (std::sys::pal::sgx: fix mismatched alloc/free alignment)
 - #161900 (bootstrap: Include feature-gated items in bootstrap tool docs)
 - #161940 (Promote `wasm32-wasip3` to a tier 2 target)
 - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`)
 - #162179 (type system const items via direct rhs)
 - #162277 (Introduce `rustc_middle::middel::resolve`)
 - #162285 (box: fixup map/try_map deallocate calls)
 - #162286 (string: don't unwind prematurely)
 - #162289 (alloc: a bunch of safety comments)
 - #162292 (Update `askama` version to `0.16.1`)
 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
 - #160906 (Suggest usize instead of placeholder type for array length constants)
 - #160936 (traits: Represent live alias arguments as bitsets)
 - #161400 (Improve diagnostics for references to closures)
 - #161656 (Suggest mutable references for FnMut closure arguments)
 - #161711 (Add more splat fn type tests)
 - #161786 (Make `tcx.def_id_partial_cmp` public)
 - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers)
 - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute)
 - #162212 (Implement `Rng` for `Box`)
 - #162246 (Fix incorrect meta span)
 - #162266 (std: fix typo)
 - #162291 (Add regression test from 1.98.1)

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request


          Rollup merge of rust-lang#162212 - a1phyr:box_random, r=joboet

c56efbc

Implement `Rng` for `Box`

Tracking issue: rust-lang#130703

Like rust-lang#159435, this implementation must be implemented before the stabilization of `Rng`.

r? @joshtriplett

GuillaumeGomez mentioned this pull request

Rollup of 25 pull requests #162300

Closed

rust-bors Bot pushed a commit that referenced this pull request


          Auto merge of #162300 - GuillaumeGomez:rollup-aWWJI58, r=GuillaumeGomez

443d9e9

Rollup of 25 pull requests

Successful merges:

 - #159074 ([PAC] FnAbi, llvm.ptrauth.resign and Session API change (2/8))
 - #159792 (A more readable debug map for IndexMaps)
 - #160745 (make closures act like MaybeDangling)
 - #161895 (std::sys::pal::sgx: fix mismatched alloc/free alignment)
 - #161940 (Promote `wasm32-wasip3` to a tier 2 target)
 - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`)
 - #162179 (type system const items via direct rhs)
 - #162277 (Introduce `rustc_middle::middel::resolve`)
 - #162285 (box: fixup map/try_map deallocate calls)
 - #162286 (string: don't unwind prematurely)
 - #162289 (alloc: a bunch of safety comments)
 - #162292 (Update `askama` version to `0.16.1`)
 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
 - #160906 (Suggest usize instead of placeholder type for array length constants)
 - #160936 (traits: Represent live alias arguments as bitsets)
 - #161400 (Improve diagnostics for references to closures)
 - #161656 (Suggest mutable references for FnMut closure arguments)
 - #161711 (Add more splat fn type tests)
 - #161786 (Make `tcx.def_id_partial_cmp` public)
 - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers)
 - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute)
 - #162212 (Implement `Rng` for `Box`)
 - #162246 (Fix incorrect meta span)
 - #162266 (std: fix typo)
 - #162291 (Add regression test from 1.98.1)

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request


          Rollup merge of rust-lang#162212 - a1phyr:box_random, r=joboet

c0c17b5

Implement `Rng` for `Box`

Tracking issue: rust-lang#130703

Like rust-lang#159435, this implementation must be implemented before the stabilization of `Rng`.

r? @joshtriplett

GuillaumeGomez mentioned this pull request

Rollup of 28 pull requests #162307

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request


          Rollup merge of rust-lang#162212 - a1phyr:box_random, r=joboet

b88a18a

Implement `Rng` for `Box`

Tracking issue: rust-lang#130703

Like rust-lang#159435, this implementation must be implemented before the stabilization of `Rng`.

r? @joshtriplett

GuillaumeGomez mentioned this pull request

Rollup of 27 pull requests #162308

Closed

rust-bors Bot pushed a commit that referenced this pull request


          Auto merge of #162308 - GuillaumeGomez:rollup-21zIph3, r=GuillaumeGomez

25c529b

Rollup of 27 pull requests

Successful merges:

 - #159074 ([PAC] FnAbi, llvm.ptrauth.resign and Session API change (2/8))
 - #159792 (A more readable debug map for IndexMaps)
 - #160745 (make closures act like MaybeDangling)
 - #161940 (Promote `wasm32-wasip3` to a tier 2 target)
 - #162030 (Prevent `--test` to be used in `rustdoc-html` testsuite)
 - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`)
 - #162179 (type system const items via direct rhs)
 - #162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`)
 - #162277 (Introduce `rustc_middle::middel::resolve`)
 - #162285 (box: fixup map/try_map deallocate calls)
 - #162286 (string: don't unwind prematurely)
 - #162289 (alloc: a bunch of safety comments)
 - #162290 (abby test DSL: AliasTyOutlivesViaEnv)
 - #162292 (Update `askama` version to `0.16.1`)
 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
 - #160906 (Suggest usize instead of placeholder type for array length constants)
 - #160936 (traits: Represent live alias arguments as bitsets)
 - #161400 (Improve diagnostics for references to closures)
 - #161656 (Suggest mutable references for FnMut closure arguments)
 - #161711 (Add more splat fn type tests)
 - #161786 (Make `tcx.def_id_partial_cmp` public)
 - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers)
 - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute)
 - #162212 (Implement `Rng` for `Box`)
 - #162246 (Fix incorrect meta span)
 - #162266 (std: fix typo)
 - #162291 (Add regression test from 1.98.1)

JonathanBrouwer mentioned this pull request

Rollup of 25 pull requests #162310

Merged

rust-bors Bot pushed a commit that referenced this pull request


          Auto merge of #162310 - JonathanBrouwer:rollup-3MKPWlW, r=JonathanBro…

6d451b7

…uwer

Rollup of 25 pull requests

Successful merges:

 - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`)
 - #162179 (type system const items via direct rhs)
 - #162255 (let people change rustc-dev-guide in-tree)
 - #162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`)
 - #162277 (Introduce `rustc_middle::middel::resolve`)
 - #162285 (box: fixup map/try_map deallocate calls)
 - #162286 (string: don't unwind prematurely)
 - #162289 (alloc: a bunch of safety comments)
 - #162290 (abby test DSL: AliasTyOutlivesViaEnv)
 - #162292 (Update `askama` version to `0.16.1`)
 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
 - #160906 (Suggest usize instead of placeholder type for array length constants)
 - #160936 (traits: Represent live alias arguments as bitsets)
 - #161394 (fix `is_homogeneous_aggregate`: use unit size, not total size )
 - #161400 (Improve diagnostics for references to closures)
 - #161656 (Suggest mutable references for FnMut closure arguments)
 - #161711 (Add more splat fn type tests)
 - #161786 (Make `tcx.def_id_partial_cmp` public)
 - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers)
 - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute)
 - #162212 (Implement `Rng` for `Box`)
 - #162246 (Fix incorrect meta span)
 - #162266 (std: fix typo)
 - #162291 (Add regression test from 1.98.1)
 - #162303 (Fix a minor spelling error in `library/std/src/sys/fs/unix.rs`)

rust-bors Bot pushed a commit that referenced this pull request


          Auto merge of #162310 - JonathanBrouwer:rollup-3MKPWlW, r=JonathanBro…

0f819a1

…uwer

Rollup of 25 pull requests

Successful merges:

 - #162072 (Add new Tier-3 target: `powerpc64-sony-ps3`)
 - #162179 (type system const items via direct rhs)
 - #162255 (let people change rustc-dev-guide in-tree)
 - #162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`)
 - #162277 (Introduce `rustc_middle::middel::resolve`)
 - #162285 (box: fixup map/try_map deallocate calls)
 - #162286 (string: don't unwind prematurely)
 - #162289 (alloc: a bunch of safety comments)
 - #162290 (abby test DSL: AliasTyOutlivesViaEnv)
 - #162292 (Update `askama` version to `0.16.1`)
 - #160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
 - #160906 (Suggest usize instead of placeholder type for array length constants)
 - #160936 (traits: Represent live alias arguments as bitsets)
 - #161394 (fix `is_homogeneous_aggregate`: use unit size, not total size )
 - #161400 (Improve diagnostics for references to closures)
 - #161656 (Suggest mutable references for FnMut closure arguments)
 - #161711 (Add more splat fn type tests)
 - #161786 (Make `tcx.def_id_partial_cmp` public)
 - #161953 (sanitizers: Implicitly disable mutually exclusive sanitizers)
 - #162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute)
 - #162212 (Implement `Rng` for `Box`)
 - #162246 (Fix incorrect meta span)
 - #162266 (std: fix typo)
 - #162291 (Add regression test from 1.98.1)
 - #162303 (Fix a minor spelling error in `library/std/src/sys/fs/unix.rs`)

rust-bors Bot merged commit 9ca49d6 into rust-lang:main

13 checks passed

rustbot added this to the 1.100.0 milestone

rust-bors Bot pushed a commit that referenced this pull request


          Unrolled build for #162212 in rollup 162310

608f733

Rollup merge of #162212 - a1phyr:box_random, r=joboet

Implement `Rng` for `Box`

Tracking issue: #130703

Like #159435, this implementation must be implemented before the stabilization of `Rng`.

r? @joshtriplett

rust-timer commented Sep 6, 2026

Collaborator

Note

This PR was benchmarked as part of triage of its containing rollup: triage URL.

Finished benchmarking commit (608f733): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	7.0%	[7.0%, 7.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-7.5%	[-11.8%, -3.2%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.6%	[-11.8%, 7.0%]	3

Cycles

This perf run didn't have relevant results for this metric.

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: missing data
Artifact size: 403.29 MiB -> 403.32 MiB (0.01%)

renovate-bot pushed a commit to renovate-bot/rust-lang-_-compiler-builtins that referenced this pull request


          Auto merge of #162310 - JonathanBrouwer:rollup-3MKPWlW, r=JonathanBro…

13cbe77

…uwer

Rollup of 25 pull requests

Successful merges:

 - rust-lang/rust#162072 (Add new Tier-3 target: `powerpc64-sony-ps3`)
 - rust-lang/rust#162179 (type system const items via direct rhs)
 - rust-lang/rust#162255 (let people change rustc-dev-guide in-tree)
 - rust-lang/rust#162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`)
 - rust-lang/rust#162277 (Introduce `rustc_middle::middel::resolve`)
 - rust-lang/rust#162285 (box: fixup map/try_map deallocate calls)
 - rust-lang/rust#162286 (string: don't unwind prematurely)
 - rust-lang/rust#162289 (alloc: a bunch of safety comments)
 - rust-lang/rust#162290 (abby test DSL: AliasTyOutlivesViaEnv)
 - rust-lang/rust#162292 (Update `askama` version to `0.16.1`)
 - rust-lang/rust#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
 - rust-lang/rust#160906 (Suggest usize instead of placeholder type for array length constants)
 - rust-lang/rust#160936 (traits: Represent live alias arguments as bitsets)
 - rust-lang/rust#161394 (fix `is_homogeneous_aggregate`: use unit size, not total size )
 - rust-lang/rust#161400 (Improve diagnostics for references to closures)
 - rust-lang/rust#161656 (Suggest mutable references for FnMut closure arguments)
 - rust-lang/rust#161711 (Add more splat fn type tests)
 - rust-lang/rust#161786 (Make `tcx.def_id_partial_cmp` public)
 - rust-lang/rust#161953 (sanitizers: Implicitly disable mutually exclusive sanitizers)
 - rust-lang/rust#162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute)
 - rust-lang/rust#162212 (Implement `Rng` for `Box`)
 - rust-lang/rust#162246 (Fix incorrect meta span)
 - rust-lang/rust#162266 (std: fix typo)
 - rust-lang/rust#162291 (Add regression test from 1.98.1)
 - rust-lang/rust#162303 (Fix a minor spelling error in `library/std/src/sys/fs/unix.rs`)

asukaminato0721 pushed a commit to asukaminato0721/rust-analyzer that referenced this pull request


          Auto merge of #162310 - JonathanBrouwer:rollup-3MKPWlW, r=JonathanBro…

671af95

…uwer

Rollup of 25 pull requests

Successful merges:

 - rust-lang/rust#162072 (Add new Tier-3 target: `powerpc64-sony-ps3`)
 - rust-lang/rust#162179 (type system const items via direct rhs)
 - rust-lang/rust#162255 (let people change rustc-dev-guide in-tree)
 - rust-lang/rust#162262 (Avoid manually instantiating some binders in error reporting with `-Znext-solver`)
 - rust-lang/rust#162277 (Introduce `rustc_middle::middel::resolve`)
 - rust-lang/rust#162285 (box: fixup map/try_map deallocate calls)
 - rust-lang/rust#162286 (string: don't unwind prematurely)
 - rust-lang/rust#162289 (alloc: a bunch of safety comments)
 - rust-lang/rust#162290 (abby test DSL: AliasTyOutlivesViaEnv)
 - rust-lang/rust#162292 (Update `askama` version to `0.16.1`)
 - rust-lang/rust#160509 (Remove `RegionExt`; move methods to `Region` in `rustc_type_ir`)
 - rust-lang/rust#160906 (Suggest usize instead of placeholder type for array length constants)
 - rust-lang/rust#160936 (traits: Represent live alias arguments as bitsets)
 - rust-lang/rust#161394 (fix `is_homogeneous_aggregate`: use unit size, not total size )
 - rust-lang/rust#161400 (Improve diagnostics for references to closures)
 - rust-lang/rust#161656 (Suggest mutable references for FnMut closure arguments)
 - rust-lang/rust#161711 (Add more splat fn type tests)
 - rust-lang/rust#161786 (Make `tcx.def_id_partial_cmp` public)
 - rust-lang/rust#161953 (sanitizers: Implicitly disable mutually exclusive sanitizers)
 - rust-lang/rust#162155 (add suggestion for `rustc_allowed_through_unstable_modules` attribute)
 - rust-lang/rust#162212 (Implement `Rng` for `Box`)
 - rust-lang/rust#162246 (Fix incorrect meta span)
 - rust-lang/rust#162266 (std: fix typo)
 - rust-lang/rust#162291 (Add regression test from 1.98.1)
 - rust-lang/rust#162303 (Fix a minor spelling error in `library/std/src/sys/fs/unix.rs`)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors T-libs