Reflection refactor ptrs by yara-blue · Pull Request #162294 · rust-lang/rust

yara-blue · 2026-09-04T12:56:25Z

Tracking issue #146922

Part of the Refactoring to many methods reflection subgoal. See that for the full context. In short for various reasons we are moving from an enum TypeKind where the variants hold the types information to one that just tells you the type kind. Separate methods on TypeId provide a way to get to the data that used to be in the variant.

Since function pointers have a lot of fields it felt better to keep the FnPtr struct we have now then add an intrinsic for each field.

r? @oli-obk

rustbot · 2026-09-04T12:56:29Z

Some changes occurred to the intrinsics. Make sure the CTFE / Miri interpreter
gets adapted for the changes, if necessary.

cc @rust-lang/miri, @RalfJung, @oli-obk, @lcnr

The reflection data structures are tied exactly to the implementation
in the compiler. Make sure to also adjust rustc_const_eval/src/const_eval/type_info.rs

cc @oli-obk

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

Some changes occurred in compiler/rustc_attr_ir

cc @jdonszelmann, @JonathanBrouwer

rustbot · 2026-09-04T12:56:32Z

oli-obk is not on the review rotation at the moment.
They may take a while to respond.

yara-blue · 2026-09-04T13:24:18Z

I originally did a straightforward port of these tests but decided to "uncouple" (testing only one "thing" per test) them also. Happy rewrite as a straightforward port.

View changes since the review

oli-obk · 2026-09-07T10:41:56Z

@bors r+ rollup

rust-bors · 2026-09-07T10:41:59Z

📌 Commit 06fa642 has been approved by oli-obk

It is now in the queue for this repository.

…uwer Rollup of 3 pull requests Successful merges: - #161896 (Remove fields from TypeKind: Array, Slice) - #162354 (Make comptime functions ineligible for coverage) - #162379 (add test ensuring we refuse to const-eval the body of a rustc_do_not_const_check function) Failed merges: - #162294 (Reflection refactor ptrs)

@oli-obk

…, r=oli-obk Reflection refactor ptrs Tracking issue rust-lang#146922 Part of the [Refactoring to many methods](https://rust-lang.zulipchat.com/#narrow/channel/572285-goals.2Freflection/topic/Refactoring.20to.20many.20methods/with/592226560) reflection subgoal. See that for the full context. In short for various reasons we are moving from an enum `TypeKind` where the variants hold the types information to one that just tells you the type kind. Separate methods on `TypeId` provide a way to get to the data that used to be in the variant. Since function pointers have a lot of fields it felt better to keep the `FnPtr` struct we have now then add an intrinsic for each field. r? @oli-obk

@oli-obk

…, r=oli-obk Reflection refactor ptrs Tracking issue rust-lang#146922 Part of the [Refactoring to many methods](https://rust-lang.zulipchat.com/#narrow/channel/572285-goals.2Freflection/topic/Refactoring.20to.20many.20methods/with/592226560) reflection subgoal. See that for the full context. In short for various reasons we are moving from an enum `TypeKind` where the variants hold the types information to one that just tells you the type kind. Separate methods on `TypeId` provide a way to get to the data that used to be in the variant. Since function pointers have a lot of fields it felt better to keep the `FnPtr` struct we have now then add an intrinsic for each field. r? @oli-obk

…uwer Rollup of 11 pull requests Successful merges: - #158153 (avoid spurious lifetime diagnostic in async generic case) - #160197 (Restrict LLVM inline asm location cookie usage. Fixes #150451) - #162413 (Unconditionally invalidate the library when the compiler changes) - #162294 (Reflection refactor ptrs) - #162354 (Make comptime functions ineligible for coverage) - #162379 (add test ensuring we refuse to const-eval the body of a rustc_do_not_const_check function) - #162386 (Add a regression test for trailing attributes in doctests) - #162410 (std: remove exceed whitespace in docs) - #162420 (mir_build: Don't pass a redundant `scrutinee_span` to some MIR-build methods) - #162430 (rustc-dev-guide subtree update) - #162431 (add next-solver FIXMEs)

@oli-obk

Rollup merge of #162294 - yara-blue:reflection-refactor-ptrs, r=oli-obk Reflection refactor ptrs Tracking issue #146922 Part of the [Refactoring to many methods](https://rust-lang.zulipchat.com/#narrow/channel/572285-goals.2Freflection/topic/Refactoring.20to.20many.20methods/with/592226560) reflection subgoal. See that for the full context. In short for various reasons we are moving from an enum `TypeKind` where the variants hold the types information to one that just tells you the type kind. Separate methods on `TypeId` provide a way to get to the data that used to be in the variant. Since function pointers have a lot of fields it felt better to keep the `FnPtr` struct we have now then add an intrinsic for each field. r? @oli-obk

…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#158153 (avoid spurious lifetime diagnostic in async generic case) - rust-lang/rust#160197 (Restrict LLVM inline asm location cookie usage. Fixes rust-lang/rust#150451) - rust-lang/rust#162413 (Unconditionally invalidate the library when the compiler changes) - rust-lang/rust#162294 (Reflection refactor ptrs) - rust-lang/rust#162354 (Make comptime functions ineligible for coverage) - rust-lang/rust#162379 (add test ensuring we refuse to const-eval the body of a rustc_do_not_const_check function) - rust-lang/rust#162386 (Add a regression test for trailing attributes in doctests) - rust-lang/rust#162410 (std: remove exceed whitespace in docs) - rust-lang/rust#162420 (mir_build: Don't pass a redundant `scrutinee_span` to some MIR-build methods) - rust-lang/rust#162430 (rustc-dev-guide subtree update) - rust-lang/rust#162431 (add next-solver FIXMEs)

rustbot assigned oli-obk Sep 4, 2026

yara-blue commented Sep 4, 2026

View reviewed changes

Comment thread compiler/rustc_attr_ir/src/lang_items.rs

yara-blue commented Sep 4, 2026

View reviewed changes

Comment thread compiler/rustc_const_eval/src/const_eval/machine.rs

yara-blue force-pushed the reflection-refactor-ptrs branch 2 times, most recently from 52f2e49 to b9b9421 Compare September 4, 2026 13:21

yara-blue commented Sep 4, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

yara-blue added 6 commits September 4, 2026 19:26

reflection: adds TypeId::points_to and TypeId::is_mutable_pointer

f123df5

reflection: remove field from TypeKind::Pointer variant

9c36788

reflection: make points_to and points_mutably support references

e46de86

reflection: remove field from TypeKind::Reference

f4cdf28

reflection: adds TypeId::function_ptr returning FnPtr

98d68aa

reflection: remove field from TypeKind::FnPtr

06fa642

yara-blue force-pushed the reflection-refactor-ptrs branch from b9b9421 to 06fa642 Compare September 4, 2026 17:28

oli-obk reviewed Sep 7, 2026

View reviewed changes

Comment thread library/core/src/mem/type_info.rs Outdated

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2026

This was referenced Sep 7, 2026

Rollup of 4 pull requests #162416

Closed

Rollup of 3 pull requests #162417

Closed

JonathanBrouwer mentioned this pull request Sep 7, 2026

Rollup of 5 pull requests #162424

Closed

This was referenced Sep 7, 2026

Rollup of 8 pull requests #162427

Closed

Rollup of 11 pull requests #162434

Merged

rust-bors Bot merged commit 706214d into rust-lang:main Sep 7, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 7, 2026

oli-obk mentioned this pull request Sep 9, 2026

reflection and comptime rust-lang/goals#406

Open

Navigation Menu

Uh oh!

Reflection refactor ptrs - #162294

Reflection refactor ptrs#162294
rust-bors[bot] merged 6 commits into
rust-lang:mainfrom
yara-blue:reflection-refactor-ptrs

yara-blue commented Sep 4, 2026

Uh oh!

rustbot commented Sep 4, 2026

Uh oh!

rustbot commented Sep 4, 2026

Uh oh!

Uh oh!

Uh oh!

yara-blue Sep 4, 2026 •

edited by rustbot

Loading

Uh oh!

This comment has been minimized.

Uh oh!

oli-obk commented Sep 7, 2026

Uh oh!

rust-bors Bot commented Sep 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

yara-blue commented Sep 4, 2026

Uh oh!

rustbot commented Sep 4, 2026

Uh oh!

rustbot commented Sep 4, 2026

Uh oh!

Uh oh!

Uh oh!

yara-blue Sep 4, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Uh oh!

oli-obk commented Sep 7, 2026

Uh oh!

rust-bors Bot commented Sep 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

yara-blue Sep 4, 2026 •

edited by rustbot

Loading