Skip to content

Fix unsoundness bug on next trait solver for dyn const generics placeholder - #162475

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
lsunsi:issue296
Sep 8, 2026
Merged

Fix unsoundness bug on next trait solver for dyn const generics placeholder#162475
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
lsunsi:issue296

Conversation

@lsunsi

@lsunsi lsunsi commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

This seem to fix the related test, which would compile on next trait solver and should not.
It's related to the linked issue where it'd lead to a segmentation fault.

Closes rust-lang/trait-system-refactor-initiative#296

r? @BoxyUwU

@rustbot

rustbot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

changes to the core type system

cc @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 8, 2026
@rustbot

rustbot commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

@BoxyUwU

BoxyUwU commented Sep 8, 2026

Copy link
Copy Markdown
Member

@bors r+ rollup

@rust-bors

rust-bors Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 265ca10 has been approved by BoxyUwU

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

Reason for tree closure: spurious failures

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Sep 8, 2026
Fix unsoundness bug on next trait solver for dyn const generics placeholder

This seem to fix the related test, which would compile on next trait solver and should not.
It's related to the linked issue where it'd lead to a segmentation fault.

Closes rust-lang/trait-system-refactor-initiative#296

r? @BoxyUwU
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
…uwer

Rollup of 6 pull requests

Successful merges:

 - #162309 (offload: automate manual clang-linker-wrapper step)
 - #160505 (delegation: supporting inherent impls)
 - #160712 (windows-gnullvm: always link libunwind statically)
 - #161423 (trait_selection: Keep type-op region constraints in borrowck)
 - #162461 (limit the api of `fold_predicate` and `visit_predicate`)
 - #162475 (Fix unsoundness bug on next trait solver for dyn const generics placeholder)
@rust-bors
rust-bors Bot merged commit faf7381 into rust-lang:main Sep 8, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 8, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 8, 2026
Rollup merge of #162475 - lsunsi:issue296, r=BoxyUwU

Fix unsoundness bug on next trait solver for dyn const generics placeholder

This seem to fix the related test, which would compile on next trait solver and should not.
It's related to the linked issue where it'd lead to a segmentation fault.

Closes rust-lang/trait-system-refactor-initiative#296

r? @BoxyUwU
@lsunsi
lsunsi deleted the issue296 branch September 8, 2026 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calling through a dyn trait with an ill-typed const segfaults

3 participants