Don't suggest `std::` rustfix paths in `#![no_std]` crates by lapla-cogito · Pull Request #163096 · rust-lang/rust

lapla-cogito · 2026-09-21T08:20:56Z

Several lints emit rustfix suggestions with hard-coded std::... paths. In #![no_std] crates those paths do not exist of course, so cargo fix can leave the crate unable to compile.

This is best reviewed per commit.

rustbot · 2026-09-21T08:21:01Z

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 77 candidates
Random selection from 18 candidates

lapla-cogito · 2026-09-21T08:23:47Z

 }
+
+/// Crate to use for rustfix / diagnostic paths that exist in both `std` and `core`. Returns `None` for `#![no_core]`.
+pub(crate) fn std_or_core(cx: &LateContext<'_>) -> Option<&'static str> {


Note that Clippy has a function that does the same thing. Once this PR is merged (and after a sync occurs), I think I’ll prepare a patch to make Clippy use the std_or_core from rustc instead.

https://github.com/rust-lang/rust-clippy/blob/df7957bde892aebe3d74c9e97f3b9f7d4a38f0f7/clippy_utils/src/lib.rs#L2054

View changes since the review

rustbot · 2026-09-23T10:34:20Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

lapla-cogito · 2026-09-23T11:06:51Z

@rustbot ready

…tfix

oli-obk · 2026-09-23T18:35:03Z

@bors r+ rollup

rust-bors · 2026-09-23T18:35:06Z

📌 Commit 2b022a3 has been approved by oli-obk

It is now in the queue for this repository.

Don't suggest `std::` rustfix paths in `#![no_std]` crates Several lints emit rustfix suggestions with hard-coded `std::...` paths. In `#![no_std]` crates those paths do not exist of course, so `cargo fix` can leave the crate unable to compile. This is best reviewed per commit.

Rollup of 8 pull requests Successful merges: - #162976 (fix quadratic naming of duplicate sidebar links) - #163222 (Enable EII tests for cg_gcc) - #162942 (Remove `StashKey::AssociatedTypeSuggestion`) - #163096 (Don't suggest `std::` rustfix paths in `#![no_std]` crates) - #163110 (Mark `std::os::wasip2` with correct doc-cfgs, mark as unstable) - #163185 (properly decrement available_depth on cycles and provisional cache hits) - #163214 (revert r14 register names for arm) - #163226 (miri subtree update)

…uwer Rollup of 14 pull requests Successful merges: - #162976 (fix quadratic naming of duplicate sidebar links) - #161275 (Refactor `core::cmp::{smallest, largest}` & add `mir-opt` test) - #163143 (cg_llvm: Use fewer FFI calls to check the target CPU's features) - #163188 (Adjust for Arm64EC name mangling when checking for exported symbols) - #163211 (`rustc_builtin_macros` cleanup, part 6) - #161386 (Don't merge distinct impl candidates) - #162942 (Remove `StashKey::AssociatedTypeSuggestion`) - #163096 (Don't suggest `std::` rustfix paths in `#![no_std]` crates) - #163110 (Mark `std::os::wasip2` with correct doc-cfgs, mark as unstable) - #163185 (properly decrement available_depth on cycles and provisional cache hits) - #163214 (revert r14 register names for arm) - #163226 (miri subtree update) - #163228 (Add regression test for trait predicate with escaping bounds) - #163234 (`rustc_dump_symbol_name`: add demangling information as a note instead)

Rollup merge of #163096 - lapla-cogito:std_or_core, r=oli-obk Don't suggest `std::` rustfix paths in `#![no_std]` crates Several lints emit rustfix suggestions with hard-coded `std::...` paths. In `#![no_std]` crates those paths do not exist of course, so `cargo fix` can leave the crate unable to compile. This is best reviewed per commit.

…uwer Rollup of 14 pull requests Successful merges: - rust-lang/rust#162976 (fix quadratic naming of duplicate sidebar links) - rust-lang/rust#161275 (Refactor `core::cmp::{smallest, largest}` & add `mir-opt` test) - rust-lang/rust#163143 (cg_llvm: Use fewer FFI calls to check the target CPU's features) - rust-lang/rust#163188 (Adjust for Arm64EC name mangling when checking for exported symbols) - rust-lang/rust#163211 (`rustc_builtin_macros` cleanup, part 6) - rust-lang/rust#161386 (Don't merge distinct impl candidates) - rust-lang/rust#162942 (Remove `StashKey::AssociatedTypeSuggestion`) - rust-lang/rust#163096 (Don't suggest `std::` rustfix paths in `#![no_std]` crates) - rust-lang/rust#163110 (Mark `std::os::wasip2` with correct doc-cfgs, mark as unstable) - rust-lang/rust#163185 (properly decrement available_depth on cycles and provisional cache hits) - rust-lang/rust#163214 (revert r14 register names for arm) - rust-lang/rust#163226 (miri subtree update) - rust-lang/rust#163228 (Add regression test for trait predicate with escaping bounds) - rust-lang/rust#163234 (`rustc_dump_symbol_name`: add demangling information as a note instead)

lapla-cogito added 2 commits September 21, 2026 14:08

Add std_or_core helper for crate-qualified rustfix paths

8955f77

Use std_or_core in undropped_manually_drops rustfix

4238ee3

rustbot assigned oli-obk Sep 21, 2026

lapla-cogito commented Sep 21, 2026

View reviewed changes

lapla-cogito force-pushed the std_or_core branch from a2e84f2 to 4e89118 Compare September 21, 2026 08:57

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 21, 2026

This comment has been minimized.

Sign in to view

lapla-cogito force-pushed the std_or_core branch from 4e89118 to e883ca3 Compare September 21, 2026 09:05

oli-obk added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2026

oli-obk requested changes Sep 23, 2026

View reviewed changes

Comment thread compiler/rustc_lint/src/transmute.rs Outdated

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2026

Use std_or_core in integer_to_ptr_transmutes rustfix

4858117

lapla-cogito force-pushed the std_or_core branch from e883ca3 to 64245e7 Compare September 23, 2026 10:54

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 23, 2026

oli-obk reviewed Sep 23, 2026

View reviewed changes

Comment thread compiler/rustc_lint/src/types.rs Outdated

lapla-cogito added 3 commits September 23, 2026 21:42

Use std_or_core in ambiguous_wide_pointer_comparisons rustfix

711d861

Use std_or_core in unpredictable_function_pointer_comparisons rus…

ed84ade

…tfix

Skip panic_any rustfix in non_fmt_panics when it is unavailable

e31fb47

lapla-cogito force-pushed the std_or_core branch from 64245e7 to e31fb47 Compare September 23, 2026 12:43

Export std_or_core

2b022a3

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2026

jhpratt mentioned this pull request Sep 23, 2026

Rollup of 8 pull requests #163236

Closed

JonathanBrouwer mentioned this pull request Sep 24, 2026

Rollup of 14 pull requests #163244

Merged

rust-bors Bot merged commit 8915d07 into rust-lang:main Sep 24, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 24, 2026

lapla-cogito deleted the std_or_core branch September 24, 2026 14:19

Navigation Menu

Uh oh!

Don't suggest `std::` rustfix paths in `#![no_std]` crates - #163096

Don't suggest `std::` rustfix paths in `#![no_std]` crates#163096
rust-bors[bot] merged 7 commits into
rust-lang:mainfrom
lapla-cogito:std_or_core

lapla-cogito commented Sep 21, 2026

Uh oh!

rustbot commented Sep 21, 2026

Uh oh!

lapla-cogito Sep 21, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

Uh oh!

rustbot commented Sep 23, 2026

Uh oh!

lapla-cogito commented Sep 23, 2026

Uh oh!

Uh oh!

oli-obk commented Sep 23, 2026

Uh oh!

rust-bors Bot commented Sep 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

lapla-cogito commented Sep 21, 2026

Uh oh!

rustbot commented Sep 21, 2026

Uh oh!

lapla-cogito Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Uh oh!

rustbot commented Sep 23, 2026

Uh oh!

lapla-cogito commented Sep 23, 2026

Uh oh!

Uh oh!

oli-obk commented Sep 23, 2026

Uh oh!

rust-bors Bot commented Sep 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lapla-cogito Sep 21, 2026 •

edited

Loading