Fix incorrect use of await in parser suggestion - #163238
Merged
rust-bors[bot] merged 2 commits intoSep 24, 2026
Merged
rust-bors[bot] merged 2 commits into
rust-bors[bot] merged 2 commits into
Conversation
Collaborator
|
The parser was modified, potentially altering the grammar of (stable) Rust cc @fmease |
Collaborator
|
r? @khyperia rustbot has assigned @khyperia. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
gosh this was a pleasant PR to review, kept on going "but what about..." and then there was a comment or test diff that answered my question~ ❤️ @bors r+ rollup |
Contributor
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 24, 2026
…suggestion-parens, r=khyperia Fix incorrect use of await in parser suggestion The old suggestion of: ```diff LL - let _ = await!(bar())?; LL + let _ = bar().await)?; ``` is wrong because of the lefted `)` was unremoved, and also here we need to take care of expr precedence.
This was referenced Sep 24, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 24, 2026
…uwer Rollup of 7 pull requests Successful merges: - #163218 (stdarch subtree update) - #159287 (Build a new incr comp session dir from scratch every time) - #163222 (Enable EII tests for cg_gcc) - #163251 (cg_gcc subtree sync 2026-09-24) - #162595 (avoid accessing uninferred closure upvars in diagnostics) - #162937 (do generic_const_args Const::Ty hack only on projection consts) - #163238 (Fix incorrect use of await in parser suggestion)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 24, 2026
Rollup merge of #163238 - chenyukang:yukang-fix-await-macro-suggestion-parens, r=khyperia Fix incorrect use of await in parser suggestion The old suggestion of: ```diff LL - let _ = await!(bar())?; LL + let _ = bar().await)?; ``` is wrong because of the lefted `)` was unremoved, and also here we need to take care of expr precedence.
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Sep 25, 2026
…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#163218 (stdarch subtree update) - rust-lang/rust#159287 (Build a new incr comp session dir from scratch every time) - rust-lang/rust#163222 (Enable EII tests for cg_gcc) - rust-lang/rust#163251 (cg_gcc subtree sync 2026-09-24) - rust-lang/rust#162595 (avoid accessing uninferred closure upvars in diagnostics) - rust-lang/rust#162937 (do generic_const_args Const::Ty hack only on projection consts) - rust-lang/rust#163238 (Fix incorrect use of await in parser suggestion)
bjorn3
pushed a commit
to rust-lang/rustc_codegen_cranelift
that referenced
this pull request
Sep 28, 2026
…uwer Rollup of 7 pull requests Successful merges: - rust-lang/rust#163218 (stdarch subtree update) - rust-lang/rust#159287 (Build a new incr comp session dir from scratch every time) - rust-lang/rust#163222 (Enable EII tests for cg_gcc) - rust-lang/rust#163251 (cg_gcc subtree sync 2026-09-24) - rust-lang/rust#162595 (avoid accessing uninferred closure upvars in diagnostics) - rust-lang/rust#162937 (do generic_const_args Const::Ty hack only on projection consts) - rust-lang/rust#163238 (Fix incorrect use of await in parser suggestion)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old suggestion of:
is wrong because of the lefted
)was unremoved, and also here we need to take care of expr precedence.