Skip to content

Prevent comparison and dereferencing of raw pointers in constexprs - #25840

Merged
bors merged 1 commit into
rust-lang:masterfrom
arielb1:ptr-compare-fixes
May 28, 2015
Merged

Prevent comparison and dereferencing of raw pointers in constexprs#25840
bors merged 1 commit into
rust-lang:masterfrom
arielb1:ptr-compare-fixes

Conversation

@arielb1

@arielb1 arielb1 commented May 27, 2015

Copy link
Copy Markdown
Contributor

Fixes #25826.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1

arielb1 commented May 27, 2015

Copy link
Copy Markdown
Contributor Author

r? @nrc

Prohibiting equality (which is needed for #25768) hurts inference too much - it can wait for rust-lang/rfcs#1135.

@rust-highfive rust-highfive assigned nrc and unassigned alexcrichton May 27, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment saying what is being tested

@nrc

nrc commented May 27, 2015

Copy link
Copy Markdown
Member

r=me with the comment added

@arielb1
arielb1 force-pushed the ptr-compare-fixes branch 4 times, most recently from 9fe22e6 to 7d69a71 Compare May 28, 2015 00:03
@nrc

nrc commented May 28, 2015

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented May 28, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 7d69a71 has been approved by nrc

@arielb1
arielb1 force-pushed the ptr-compare-fixes branch from 7d69a71 to 080311d Compare May 28, 2015 00:23
@nrc

nrc commented May 28, 2015

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented May 28, 2015

Copy link
Copy Markdown
Collaborator

📌 Commit 080311d has been approved by nrc

bors added a commit that referenced this pull request May 28, 2015
@bors

bors commented May 28, 2015

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 080311d with merge 6a3d55a...

@bors

bors commented May 28, 2015

Copy link
Copy Markdown
Collaborator

@bors
bors merged commit 080311d into rust-lang:master May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Raw pointer comparisons are valid constant expressions

5 participants