Skip to content

Remove the unstable and deprecated mpsc_select - #60921

Merged
bors merged 1 commit into
rust-lang:masterfrom
cuviper:remove-mpsc_select
May 20, 2019
Merged

Remove the unstable and deprecated mpsc_select#60921
bors merged 1 commit into
rust-lang:masterfrom
cuviper:remove-mpsc_select

Conversation

@cuviper

@cuviper cuviper commented May 17, 2019

Copy link
Copy Markdown
Member

This removes macro select! and std::sync::mpsc::{Handle, Select},
which were all unstable and have been deprecated since 1.32.

Closes #27800
r? @SimonSapin

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2019
@cuviper

cuviper commented May 17, 2019

Copy link
Copy Markdown
Member Author

Note: Beyond the API changes, I only removed obviously unused/unreachable code. I suspect more cleanup is possible, like the remaining abort_selection() calls.

cc @stjepang @stepancheg

@rust-highfive

This comment has been minimized.

This removes macro `select!` and `std::sync::mpsc::{Handle, Select}`,
which were all unstable and have been deprecated since 1.32.
@cuviper
cuviper force-pushed the remove-mpsc_select branch from 99e77a8 to f950193 Compare May 17, 2019 19:17
@SimonSapin

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented May 19, 2019

Copy link
Copy Markdown
Collaborator

📌 Commit f950193 has been approved by SimonSapin

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 19, 2019
@bors

bors commented May 20, 2019

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f950193 with merge 589beb9...

bors added a commit that referenced this pull request May 20, 2019
Remove the unstable and deprecated mpsc_select

This removes macro `select!` and `std::sync::mpsc::{Handle, Select}`,
which were all unstable and have been deprecated since 1.32.

Closes #27800
r? @SimonSapin
@bors

bors commented May 20, 2019

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-travis, status-appveyor
Approved by: SimonSapin
Pushing 589beb9 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 20, 2019
@bors
bors merged commit f950193 into rust-lang:master May 20, 2019
@cuviper
cuviper deleted the remove-mpsc_select branch May 20, 2019 17:21
@Timmmm Timmmm mentioned this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking issue for channel selection

4 participants