Improve code clarity - #64935

Merged

bors merged 23 commits into

rust-lang:masterfrom

AnthonyMikh:librustc_errors/emmiter__code-clarity

Oct 1, 2019

Commits on Sep 25, 2019

Use `saturating_sub` where applicable
AnthonyMikh
authored
2cb460e
Use `max` instead of `if`s
AnthonyMikh
authored
e9a93be
Simplify Unicode-aware trimming
AnthonyMikh
authored
4fc5650
Use map + sum instead of fold for computing Unicode width
AnthonyMikh
authored
d6327e8
Use Option::map_or where applicable
AnthonyMikh
authored
aef169b
Unify order of variables in chained comparison
AnthonyMikh
authored
9b447e2
Simplify `Emitter::fix_multispan_in_std_macros`
AnthonyMikh
authored
f93827f
Use `sort_by_key` rather than `sort_by`
AnthonyMikh
authored
ea32862
Simplify `style_or_override`
AnthonyMikh
authored
7a0725f

Commits on Sep 26, 2019

Revert "Simplify Unicode-aware trimming"
AnthonyMikh
authored
75a7c27

Commits on Sep 30, 2019

Simplify code for special case of annotation
AnthonyMikh
authored
7dc953b
Simplify `EmitterWriter::get_multispan_max_line_num`
AnthonyMikh
authored
6b6a79b
Simplify `EmitterWriter::get_max_line_num`
AnthonyMikh
authored
7b4c5c6
Update doc comment for `style_or_override`
AnthonyMikh
authored
21724ed
Simplify `EmitterWriter::emit_suggestion_default`
AnthonyMikh
authored
7a807c5
Remove redundant `.iter_mut()`
AnthonyMikh
authored
9d73176
Simplify a conditional in `collect_annotations`
AnthonyMikh
authored
55b5428
Use pattern matching instead of indexing tuples
AnthonyMikh
authored
bb44288
(fmt) remove trailing whitespaces
AnthonyMikh
authored
e5db5b3
Fix errors
AnthonyMikh
authored
61bc38e
Ascript type explicitly
AnthonyMikh
authored
515262c

Commits on Oct 1, 2019

Hint type for `.sum()`
AnthonyMikh
authored
fdce416
Fix borrowck errors
AnthonyMikh
authored
50c2a58