rc: Use ~T for allocation - #8022
Closed
bluss wants to merge 1 commit into
Closed
Conversation
Simplify Rc<T>/RcMut<T> by using ~T when allocating a reference counted box.
Contributor
Author
|
There is a new kind |
Contributor
|
@blake2-ppc: I'm not sure. Do you mean adding it as the type bound? |
Contributor
Author
|
Using 'static it instead of <T: Send>, if it's possible. |
Contributor
|
Landing as part of #7982. |
Contributor
|
@blake2-ppc: I'm not sure if it would be enough, |
Contributor
Author
|
Rc and RcMut are 'static. I think that using 'static and making Rc/RcMut non-static is a different tradeoff and probably not what's wanted. |
U007D
pushed a commit
to U007D/rust-mos
that referenced
this pull request
Aug 21, 2026
8021: Enable searching for builtin types r=matklad a=Veykril Not too sure how useful this is for reference search overall, but for completeness sake it should be there  Also enables document highlighting for them. 8022: some clippy::performance fixes r=matklad a=matthiaskrgr use vec![] instead of Vec::new() + push() avoid redundant clones use chars instead of &str for single char patterns in ends_with() and starts_with() allocate some Vecs with capacity to avoid unnecessary resizing Co-authored-by: Lukas Wirth <lukastw97@gmail.com> Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify Rc/RcMut by using ~T when allocating a reference counted
box.
cc @thestinger