Skip to content

Make params be SmallVec as originally was - #97670

Merged
bors merged 1 commit into
rust-lang:masterfrom
spastorino:simplify-universal-impl-trait-lowering2
Jun 4, 2022
Merged

Make params be SmallVec as originally was#97670
bors merged 1 commit into
rust-lang:masterfrom
spastorino:simplify-universal-impl-trait-lowering2

Conversation

@spastorino

@spastorino spastorino commented Jun 3, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

r? @cjgillot
It was originally a SmallVec, I've mistakenly changed it here to a Vec

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 3, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 3, 2022
@Dylan-DPC

Dylan-DPC commented Jun 3, 2022

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jun 3, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit b051fca has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 3, 2022
@Dylan-DPC
Rollup merge of rust-lang#97670 - spastorino:simplify-universal-impl-…
568d0b7 
…trait-lowering2, r=Dylan-DPC

Make params be SmallVec as originally was

r? `@cjgillot`
It was originally a [`SmallVec`](https://github.com/rust-lang/rust/pull/97598/files#diff-0a61b538a3cec072c76fecae4635af6a12ec3256860029ac70549c2aa53ab394L1497), I've mistakenly changed it [here](https://github.com/rust-lang/rust/pull/97598/files#diff-0a61b538a3cec072c76fecae4635af6a12ec3256860029ac70549c2aa53ab394R1377) to a `Vec`
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 3, 2022
Closed
@spastorino

spastorino commented Jun 3, 2022

Copy link
Copy Markdown
Member Author

@bors rollup=never

It probably has perf implications that would be good to know separately from other PRs.

@bors

bors commented Jun 3, 2022

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b051fca with merge f15370b...

@bors

bors commented Jun 4, 2022

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Dylan-DPC
Pushing f15370b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 4, 2022
@bors
bors merged commit f15370b into rust-lang:master Jun 4, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 4, 2022
@rust-timer

rust-timer commented Jun 4, 2022

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (f15370b): comparison url.

Instruction count

  • Primary benchmarks: 🎉 relevant improvements found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -0.2% -0.2% 3
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -0.2% -0.2% 3

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: 😿 relevant regression found
mean1 max count2
Regressions 😿
(primary)		 3.7% 3.7% 1
Regressions 😿
(secondary)		 4.2% 4.2% 1
Improvements 🎉
(primary)		 -2.1% -2.1% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 0.8% 3.7% 2

Cycles

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvement found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -2.1% -2.1% 1
All 😿🎉 (primary) N/A N/A 0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@cjgillot cjgillot

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

7 participants

@spastorino @Dylan-DPC @bors @rust-timer @cjgillot @rust-highfive @rustbot