Add splat formatting regression tests - #7032
Merged
Merged
Conversation
Manishearth
approved these changes
Aug 17, 2026
ytmimi
approved these changes
Aug 17, 2026
Member
Author
|
Note: these tests also act as regression tests for #6590 . |
This was referenced Aug 18, 2026
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 4, 2026
…r=jieyouxu Add more splat fn type tests Tracking issue: rust-lang#153629 This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR. These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang#158603, rust-lang#159643). The `rustfmt::skip` is required until rust-lang#161709 reaches stable.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 4, 2026
…r=jieyouxu Add more splat fn type tests Tracking issue: rust-lang#153629 This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR. These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang#158603, rust-lang#159643). The `rustfmt::skip` is required until rust-lang#161709 reaches stable.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 4, 2026
…r=jieyouxu Add more splat fn type tests Tracking issue: rust-lang#153629 This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR. These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang#158603, rust-lang#159643). The `rustfmt::skip` is required until rust-lang#161709 reaches stable.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 4, 2026
…r=jieyouxu Add more splat fn type tests Tracking issue: rust-lang#153629 This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR. These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang#158603, rust-lang#159643). The `rustfmt::skip` is required until rust-lang#161709 reaches stable.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Sep 4, 2026
…r=jieyouxu Add more splat fn type tests Tracking issue: rust-lang#153629 This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR. These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang#158603, rust-lang#159643). The `rustfmt::skip` is required until rust-lang#161709 reaches stable.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 4, 2026
…r=jieyouxu Add more splat fn type tests Tracking issue: rust-lang#153629 This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR. These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang#158603, rust-lang#159643). The `rustfmt::skip` is required until rust-lang#161709 reaches stable.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 5, 2026
…r=jieyouxu Add more splat fn type tests Tracking issue: rust-lang#153629 This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR. These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang#158603, rust-lang#159643). The `rustfmt::skip` is required until rust-lang#161709 reaches stable.
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 5, 2026
Rollup merge of #161711 - teor2345:more-splat-fn-ptr-tests, r=jieyouxu Add more splat fn type tests Tracking issue: #153629 This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR. These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (#158603, #159643). The `rustfmt::skip` is required until #161709 reaches stable.
renovate-bot
pushed a commit
to renovate-bot/rust-lang-_-compiler-builtins
that referenced
this pull request
Sep 7, 2026
Add more splat fn type tests Tracking issue: rust-lang/rust#153629 This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR. These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang/rust#158603, rust-lang/rust#159643). The `rustfmt::skip` is required until rust-lang/rust#161709 reaches stable.
asukaminato0721
pushed a commit
to asukaminato0721/rust-analyzer
that referenced
this pull request
Sep 7, 2026
Add more splat fn type tests Tracking issue: rust-lang/rust#153629 This PR turns some rustfmt splat tests from rust-lang/rustfmt#7032 into rustc UI tests. It is a test-only PR. These tests check _invalid_ function pointer / function type splatting, which has had recent ICE fixes (rust-lang/rust#158603, rust-lang/rust#159643). The `rustfmt::skip` is required until rust-lang/rust#161709 reaches stable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unstable Rust compiler feature tracking issue: rust-lang/rust#153629
I created these tests to track down a code formatting bug where the
#[rustc_splat]attribute is deleted in function pointer types.These tests pass on recent nightly versions of rustfmt, but fail on recent beta (2026-08-14) and stable versions. I've asked how to fix this in Zulip.
Update: this bug was fixed in #6590 which is pending a rust-lang/rust subtree sync. When the sync happens, nightly rustfmt releases will be fixed.
The syntax of this feature is still unstable, so the goal of these tests is to check attribute formatting.