Switch to git-testament rather than old build.rs - #1701
Merged
Conversation
Contributor
|
☔ The latest upstream changes (presumably #1711) made this pull request unmergeable. Please resolve the merge conflicts. |
kinnison
force-pushed
the
kinnison/better-git-version
branch
from
March 14, 2019 21:40
58d9fc9 to
103bdfd
Compare
Contributor
|
☔ The latest upstream changes (presumably #1704) made this pull request unmergeable. Please resolve the merge conflicts. |
kinnison
force-pushed
the
kinnison/better-git-version
branch
3 times, most recently
from
April 3, 2019 09:40
cf6a053 to
1ad73fa
Compare
kinnison
marked this pull request as ready for review
April 3, 2019 09:48
kinnison
force-pushed
the
kinnison/better-git-version
branch
from
April 3, 2019 13:35
1ad73fa to
6b95547
Compare
kinnison
force-pushed
the
kinnison/better-git-version
branch
from
April 10, 2019 08:30
6b95547 to
a588ac5
Compare
nrc
approved these changes
Apr 11, 2019
nrc
left a comment
Member
There was a problem hiding this comment.
Needs rebasing, feel free to merge after that
Rather than the previous not-very-informative version string which was generated by build.rs and then not updated unless build.rs was touched, use the new `git-testament` crate which does a more complete job at compile time via a proc-macro. Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
kinnison
force-pushed
the
kinnison/better-git-version
branch
from
April 11, 2019 07:07
a588ac5 to
3772516
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than the previous not-very-informative version string
which was generated by
build.rsand then not updated unlessbuild.rswas touched, use the newgit-testamentcrate whichdoes a more complete job at compile time via a proc-macro.
Signed-off-by: Daniel Silverstone dsilvers@digital-scurf.org